Added aac to the list of sounds in RequestUtils.js#260
Merged
lannymcnie merged 1 commit intoCreateJS:masterfrom Mar 26, 2019
Merged
Added aac to the list of sounds in RequestUtils.js#260lannymcnie merged 1 commit intoCreateJS:masterfrom
lannymcnie merged 1 commit intoCreateJS:masterfrom
Conversation
Member
|
Thanks! |
Contributor
Author
|
@lannymcnie can you please do a release to npm to up the version to include this change? The latest version on npm seems to have been 2 years ago: https://www.npmjs.com/package/preloadjs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem with the current state of the file is that if you're loading a sound that's in the AAC format(usually used in safari and edge), this isn't handled by the switch statement and thus defaults to text, so the would be Audio object becomes stringified.