Conversation
ltitanb
reviewed
Aug 25, 2025
ltitanb
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #362 by adding support for the
X-Timeout-Msheader to incoming/getHeaderrequests.Since the PBS service already calculates the remaining time in a slot and has a configuration setting for a timeout variable anyway, this just puts whatever timeout is left into that header and sends it to the relay. However, if the proposer provides a valid header value within its request, this will use whichever of those two is shortest. It wouldn't make sense for the proposer to request a longer timeout than would actually be possible before missing the slot, hence why the minimum is used.