feat(pbs): add retry limit for validator registration (#316)#322
Merged
ltitanb merged 4 commits intoCommit-Boost:mainfrom Jun 11, 2025
Merged
Conversation
ltitanb
requested changes
Jun 8, 2025
Collaborator
ltitanb
left a comment
There was a problem hiding this comment.
Looks great, thanks for the PR! Left a small suggestion + lint check failed
abb4fd0 to
029b664
Compare
ltitanb
approved these changes
Jun 11, 2025
Collaborator
ltitanb
left a comment
There was a problem hiding this comment.
looks great, thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR resolves #316 by introducing a configurable retry limit for validator registration requests. The goal is to prevent unnecessary network traffic, reduce load on relays, and avoid log clutter caused by excessive retries on client-side errors (e.g., 400, 429).
💡 Motivation and Context
if a relay responded with errors like 400 (unknown validator) or 429 (too many requests), client would keep retrying continously. This PR adds a limit to those retries to avoid putting unnecessary load on relays and to keep the logs clean.
What is Included
register_validator_retry_limitto PbsConfig (default = 3)send_register_validator_with_timeoutto cap total attemptsmax retry < retry_limitBehavior
register_validator_retry_limit= 3:retry = 0, 1, 2Issue
Closes #316