Skip to content

Improved responsiveness of Showcase form & removed empty ruleset.#1532

Closed
Zack-Dx wants to merge 0 commit intoCodingTrain:mainfrom
Zack-Dx:main
Closed

Improved responsiveness of Showcase form & removed empty ruleset.#1532
Zack-Dx wants to merge 0 commit intoCodingTrain:mainfrom
Zack-Dx:main

Conversation

@Zack-Dx
Copy link

@Zack-Dx Zack-Dx commented Mar 25, 2024

Hello, I noticed that the submission form select and fields were not responsive for a device with a maximum width of 400px.

Before:

Before

After I fixed it, ensuring the rest of the responsive elements are in place:

After
  • Also eliminated a single unneeded ruleset.

@netlify
Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for codingtrain ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0b47fc8
🔍 Latest deploy log https://app.netlify.com/sites/codingtrain/deploys/661231587e2998000715770d
😎 Deploy Preview https://deploy-preview-1532--codingtrain.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shiffman
Copy link
Member

Thank you for this, wow! I will test this soon and hopefully merge! @dipamsen or @fturmel feel free to take a look too if you have a minute!

@fturmel
Copy link
Collaborator

fturmel commented Mar 30, 2024

I like it! Could we try using 100% instead of arbitrary pixel values, and apply them to the --small (600px) breakpoint instead? That way the fields will fill up the width more consistently and we'll get rid of the remaining broken state between 400px and ~525px browser width.

As for removing the empty root css class in the tracks Header component, it wasn't bothering me since most components are structured with a root class and roughly 5 of them are empty.

If we do want to remove the empty class properly though, the reference to it in the component should also be deleted:

<header className={css.root}>

@Zack-Dx Zack-Dx closed this Apr 7, 2024
@shiffman
Copy link
Member

shiffman commented Apr 7, 2024

Hi @Zack-Dx did you mean to close this? I would like to incorporate it! Apologies for not following up about it sooner.

@Zack-Dx
Copy link
Author

Zack-Dx commented Apr 7, 2024

Hi @Zack-Dx did you mean to close this? I would like to incorporate it! Apologies for not following up about it sooner.

No issues Shiffman, I'll create a new PR fixing this. I'm just busy these days a bit due to my exams. I'll fix it by the upcoming weekend. Thanks, I love you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants