Skip to content

fix: ensure style element for print dialog #2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Danielku15 merged 1 commit into from
Jan 7, 2026
Merged

fix: ensure style element for print dialog #2480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 42 additions & 14 deletions packages/alphatab/src/platform/javascript/BrowserUiFacade.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,14 @@ interface ResultPlaceholder extends HTMLElement {
*/
interface RegisteredWebFont {
hash: number;
element: HTMLStyleElement;
usages: number;
cssSource: string;
elements: Map<
HTMLDocument,
{
element: HTMLStyleElement;
usages: number;
}
>;
fontSuffix: string;
checker: FontLoadingChecker;
}
Expand Down Expand Up @@ -233,11 +239,20 @@ export class BrowserUiFacade implements IUiFacade<unknown> {
}

public destroy(): void {
(this.rootContainer as HtmlElementContainer).element.innerHTML = '';
const element = (this.rootContainer as HtmlElementContainer).element;
element.innerHTML = '';
const webFont = this._webFont;
webFont.usages--;
if (webFont.usages <= 0) {
webFont.element.remove();

const styleElement = webFont.elements.get(element.ownerDocument);
if (styleElement) {
styleElement.usages--;
if (styleElement.usages <= 0) {
styleElement.element.remove();
webFont.elements.delete(element.ownerDocument);
}
}

if (webFont.elements.size === 0) {
BrowserUiFacade._registeredWebFonts.delete(webFont.hash);
}
}
Expand Down Expand Up @@ -390,8 +405,8 @@ export class BrowserUiFacade implements IUiFacade<unknown> {
const registeredWebFonts = BrowserUiFacade._registeredWebFonts;
if (registeredWebFonts.has(hash)) {
const webFont = registeredWebFonts.get(hash)!;
webFont.usages++;
webFont.checker.fontLoaded.on(this._onFontLoaded.bind(this));
this._createStyleElement(webFont, root);
this._webFont = webFont;
return;
}
Expand Down Expand Up @@ -426,10 +441,6 @@ export class BrowserUiFacade implements IUiFacade<unknown> {
overflow: visible !important;
}`;

const styleElement = root.createElement('style');
styleElement.id = `alphaTabStyle${fontSuffix}`;
styleElement.innerHTML = css;
root.getElementsByTagName('head').item(0)!.appendChild(styleElement);
const checker = new FontLoadingChecker([familyName]);
checker.fontLoaded.on(this._onFontLoaded.bind(this));
this._fontCheckers.set(familyName, checker);
Expand All @@ -439,15 +450,32 @@ export class BrowserUiFacade implements IUiFacade<unknown> {

const webFont: RegisteredWebFont = {
hash,
element: styleElement,
elements: new Map(),
fontSuffix,
usages: 1,
checker
checker,
cssSource: css
};

this._createStyleElement(webFont, root);

registeredWebFonts.set(hash, webFont);
this._webFont = webFont;
}
private _createStyleElement(webFont: RegisteredWebFont, root: Document) {
if (webFont.elements.has(root)) {
webFont.elements.get(root)!.usages++;
return;
}

const styleElement = root.createElement('style');
styleElement.id = `alphaTabStyle${webFont.fontSuffix}`;
styleElement.innerHTML = webFont.cssSource;
root.getElementsByTagName('head').item(0)!.appendChild(styleElement);
webFont.elements.set(root, {
element: styleElement,
usages: 1
});
}

private static _cssFormat(format: FontFileFormat) {
switch (format) {
Expand Down
Loading