Skip to content

fix: use innerText when loading alphaTex from dom #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Danielku15 merged 1 commit into from
Dec 6, 2025
Merged

fix: use innerText when loading alphaTex from dom #2417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/alphatab/src/platform/javascript/BrowserUiFacade.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,8 @@ export class BrowserUiFacade implements IUiFacade<unknown> {
this._contents = '';
const element: HtmlElementContainer = api.container as HtmlElementContainer;
if (settings.core.tex) {
this._contents = element.element.innerHTML;
element.element.innerHTML = '';
this._contents = element.element.innerText;
element.element.innerText = '';
}
this._createStyleElements(settings);
this._file = settings.core.file;
Expand Down
2 changes: 1 addition & 1 deletion packages/alphatab/src/platform/javascript/HtmlElementContainer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,6 @@ export class HtmlElementContainer implements IContainer {
}

public clear(): void {
this.element.innerHTML = '';
this.element.innerText = '';
}
}
4 changes: 2 additions & 2 deletions packages/playground/alphatex-editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ async function load<T>(url: URL, type: XMLHttpRequest['responseType']): Promise<
async function setupEditor(api: alphaTab.AlphaTabApi, element: HTMLElement) {
Split(['#editor-wrap', '#alphatab-wrap']);

const initialCode = sessionStorage.getItem('alphatex-editor.code') ?? trimCode(element.innerHTML);
element.innerHTML = '';
const initialCode = sessionStorage.getItem('alphatex-editor.code') ?? trimCode(element.innerText);
element.innerText = '';

await setupMonaco();

Expand Down
Loading