Skip to content

fix(alphatex): Clef names #2282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Danielku15 merged 1 commit into from
Aug 18, 2025
Merged

fix(alphatex): Clef names #2282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/importer/AlphaTexImporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,10 +805,10 @@ export class AlphaTexImporter extends ScoreImporter {
case 'bass':
return Clef.F4;
case 'c3':
case 'tenor':
case 'alto':
return Clef.C3;
case 'c4':
case 'alto':
case 'tenor':
return Clef.C4;
case 'n':
case 'neutral':
Expand All @@ -826,6 +826,8 @@ export class AlphaTexImporter extends ScoreImporter {
*/
private parseClefFromInt(i: number): Clef {
switch (i) {
case 0:
return Clef.Neutral;
case 43:
return Clef.G2;
case 65:
Expand Down
25 changes: 20 additions & 5 deletions test/importer/AlphaTexImporter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1965,12 +1965,27 @@ describe('AlphaTexImporterTest', () => {

it('clefs', () => {
const score = parseTex(`
\\clef C4 \\ottava 15ma C4 | C4
\\clef C4 \\ottava 15ma C4 | C4 |
\\clef 0 | \\clef 48 | \\clef 60 | \\clef 65 | \\clef 43 |
\\clef Neutral | \\clef C3 | \\clef C4 | \\clef F4 | \\clef G2 |
\\clef "Neutral" | \\clef "C3" | \\clef "C4" | \\clef "F4" | \\clef "G2" |
\\clef n | \\clef alto | \\clef tenor | \\clef bass | \\clef treble |
\\clef "n" | \\clef "alto" | \\clef "tenor" | \\clef "bass" | \\clef "treble"
`);
expect(score.tracks[0].staves[0].bars[0].clef).to.equal(Clef.C4);
expect(score.tracks[0].staves[0].bars[0].clefOttava).to.equal(Ottavia._15ma);
expect(score.tracks[0].staves[0].bars[1].clef).to.equal(Clef.C4);
expect(score.tracks[0].staves[0].bars[1].clefOttava).to.equal(Ottavia._15ma);
let barIndex = 0;
expect(score.tracks[0].staves[0].bars[barIndex].clef).to.equal(Clef.C4);
expect(score.tracks[0].staves[0].bars[barIndex++].clefOttava).to.equal(Ottavia._15ma);
expect(score.tracks[0].staves[0].bars[barIndex].clef).to.equal(Clef.C4);
expect(score.tracks[0].staves[0].bars[barIndex++].clefOttava).to.equal(Ottavia._15ma);

for (let i = 0; i < 5; i++) {
expect(score.tracks[0].staves[0].bars[barIndex++].clef).to.equal(Clef.Neutral, `Invalid clef at index ${barIndex - 1}`);
expect(score.tracks[0].staves[0].bars[barIndex++].clef).to.equal(Clef.C3, `Invalid clef at index ${barIndex - 1}`);
expect(score.tracks[0].staves[0].bars[barIndex++].clef).to.equal(Clef.C4, `Invalid clef at index ${barIndex - 1}`);
expect(score.tracks[0].staves[0].bars[barIndex++].clef).to.equal(Clef.F4, `Invalid clef at index ${barIndex - 1}`);
expect(score.tracks[0].staves[0].bars[barIndex++].clef).to.equal(Clef.G2, `Invalid clef at index ${barIndex - 1}`);
}

testExportRoundtrip(score);
});

Expand Down
Loading