added "priority" flag of a message #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iVariable
requested changes
Jan 10, 2017
Member
iVariable
left a comment
iVariable
left a comment
There was a problem hiding this comment.
Thx for PR!
Please see comments.
| { | ||
| if (in_array($priority, array('high', 'normal'), true)) { | ||
| $this->priority = $priority; | ||
| } |
Member
There was a problem hiding this comment.
Pls add else throw Exception.
We should not mask possible dev typos.
| * Optional. | ||
| * | ||
| * @var string | ||
| */ |
Member
There was a problem hiding this comment.
Let's move those string constants to explicit constants of this class.
const PRIORITY_NORMAL, etc
iVariable
approved these changes
Jan 13, 2017
Member
|
Merged, released as v0.5. Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.