Stop safari from blowing up #177
Conversation
pace.coffee
Outdated
There was a problem hiding this comment.
@Friss I'm a bit confused here. val in from compiles to from.indexOf(val) >= 0. But from is an object like window.WebSocket, which doesn't have an indexOf method... right?
There was a problem hiding this comment.
This is true. :/ It accidentally works since it always returns -1 thus never tries to access those keys.
The keys that are a issue are the ones that are undefined. (URL, etc)
So I guess this puts the fix back on the drawing board. Though safari still seems to work with pace with this fix.
There was a problem hiding this comment.
You might want to try using Object.defineProperty (if the browser supports it). Other projects have used to avoid this error: apache/cordova-js@6c7a76f
|
Updated @TrevorBurnham seems to be working as expected now. |
pace.coffee
Outdated
There was a problem hiding this comment.
I believe you still want to use to[key] = val in browsers where Object.defineProperty is not defined.
|
How does this look @TrevorBurnham |
|
👍 |
Stop safari from blowing up
|
Tagged as v1.0.2. |
2 participants
Fixes #138 and #173
@zackbloom @TrevorBurnham @marcneuwirth