Refactor login command#268
Open
hkmatsumoto wants to merge 11 commits intoCloud-CV:masterfrom
hkmatsumoto:refactor-login-command
Open
Refactor login command#268hkmatsumoto wants to merge 11 commits intoCloud-CV:masterfrom hkmatsumoto:refactor-login-command
hkmatsumoto wants to merge 11 commits intoCloud-CV:masterfrom
hkmatsumoto:refactor-login-command
Conversation
|
@takitsuse Also can you move the refactored code to and use login.py just as a wrapper. This would enable us to keep all the functionality in one place and click wrappers in one place. |
Contributor
Author
|
@pushkalkatara I got it. I'll make changes after school classes end. |
krtkvrm
reviewed
Jan 21, 2020
krtkvrm
approved these changes
Jan 21, 2020
krtkvrm
suggested changes
Jan 21, 2020
Contributor
Author
|
@vkartik97 I'm struggling to do so. The added test passes but it somehow affects other tests. |
Contributor
Author
|
@vkartik97 By the way, could you take a look at #263? I think the PR very important to know the actual code coverage. |
Contributor
Author
|
@vkartik97 After a bitter fight, I successfully fixed the build. Please take another look 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
I removed the code duplication between:
https://github.com/Cloud-CV/evalai-cli/blob/master/evalai/login.py#L21-L25
https://github.com/Cloud-CV/evalai-cli/blob/master/evalai/login.py#L29-L33
@vkartik97 @yashdusing @RishabhJain2018 @pushkalkatara @Ram81
Could you take a look? Thanks in advance!