fix: harden SSH and Samba setup flows#1242
Open
Abs313a wants to merge 2 commits intoChrisTitusTech:mainfrom
Open
fix: harden SSH and Samba setup flows#1242Abs313a wants to merge 2 commits intoChrisTitusTech:mainfrom
Abs313a wants to merge 2 commits intoChrisTitusTech:mainfrom
Conversation
Contributor
Author
|
Implemented and validated the SSH/Samba hardening changes. What changed:
Validation performed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Summary
Issues addressed
smbpasswd -aonly works for an existing local Unix account, which caused setup failure for valid-looking but nonexistent usernames.smbpasswd -aanyway.testparmbefore enabling services.smb.conffor its success output.sudo -S, even though the shared escalation path also allowsdoas.~/.ssh/configusing fixed line ranges, which was inconsistent with the host blocks it actually writes.Issues / other PRs related
Screenshots (if applicable)