Add sending freeform reactions#1
Open
frebib wants to merge 6 commits intoChelseaDH:feature/emoji-searchfrom
Open
Add sending freeform reactions#1frebib wants to merge 6 commits intoChelseaDH:feature/emoji-searchfrom
frebib wants to merge 6 commits intoChelseaDH:feature/emoji-searchfrom
Conversation
Changes: - Ensures search state is cleared when the bottom sheet is dismissed - Adds padding below search bar - Moves search placeholder into string resource - Moves emoji grid into composable for reuse within the EmojiPicker - Only displays existing emoji picker tabs when search is not active
|
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
frebib
commented
Apr 7, 2024
...droid/features/messages/impl/timeline/components/customreaction/CustomReactionBottomSheet.kt
Outdated
Show resolved
Hide resolved
frebib
force-pushed
the
frebib/freeform-reaction
branch
from
3c1a677 to
b8e6e4f
Compare
Signed-off-by: Joe Groocock <me@frebib.net>
frebib
force-pushed
the
frebib/freeform-reaction
branch
from
b8e6e4f to
d78dfbe
Compare
frebib
force-pushed
the
feature/emoji-search
branch
4 times, most recently
from
ab4f208 to
7ae884b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.