-
-
Notifications
You must be signed in to change notification settings - Fork 41
[Chore] bump version to 1.3.7 #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update core version to 1.3.7 and synchronize peer dependencies across all adapters and extensions.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (26)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @dingyi222666, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on a routine version update for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly bumps the version of koishi-plugin-chatluna to 1.3.7 and updates the peerDependencies in all related packages to match. The changes are consistent and align with the PR's goal. I have one suggestion to improve the maintainability of this monorepo by using pnpm's workspace: protocol. This would automate these version updates in the future, making the release process smoother. See my detailed comment.
| "peerDependencies": { | ||
| "koishi": "^4.18.9", | ||
| "koishi-plugin-chatluna": "^1.3.6" | ||
| "koishi-plugin-chatluna": "^1.3.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better long-term maintainability, consider using pnpm's workspace: protocol to manage internal dependencies within this monorepo. This would automate the process of updating versions across packages.
By using "koishi-plugin-chatluna": "workspace:^" here and applying this pattern across all packages, pnpm will automatically replace workspace:^ with the correct version from the workspace (e.g., ^1.3.7) when you publish the packages. This eliminates the need for manual updates in PRs like this one, reducing maintenance overhead and the potential for errors.
You can read more about this in the pnpm documentation.
| "koishi-plugin-chatluna": "^1.3.7" | |
| "koishi-plugin-chatluna": "workspace:^" |
| "peerDependencies": { | ||
| "koishi": "^4.18.9", | ||
| "koishi-plugin-chatluna": "^1.3.6" | ||
| "koishi-plugin-chatluna": "^1.3.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better long-term maintainability, consider using pnpm's workspace: protocol to manage internal dependencies within this monorepo. This would automate the process of updating versions across packages.
By using "koishi-plugin-chatluna": "workspace:^" here and applying this pattern across all packages, pnpm will automatically replace workspace:^ with the correct version from the workspace (e.g., ^1.3.7) when you publish the packages. This eliminates the need for manual updates in PRs like this one, reducing maintenance overhead and the potential for errors.
You can read more about this in the pnpm documentation.
| "koishi-plugin-chatluna": "^1.3.7" | |
| "koishi-plugin-chatluna": "workspace:^" |
| "peerDependencies": { | ||
| "koishi": "^4.18.9", | ||
| "koishi-plugin-chatluna": "^1.3.6" | ||
| "koishi-plugin-chatluna": "^1.3.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better long-term maintainability, consider using pnpm's workspace: protocol to manage internal dependencies within this monorepo. This would automate the process of updating versions across packages.
By using "koishi-plugin-chatluna": "workspace:^" here and applying this pattern across all packages, pnpm will automatically replace workspace:^ with the correct version from the workspace (e.g., ^1.3.7) when you publish the packages. This eliminates the need for manual updates in PRs like this one, reducing maintenance overhead and the potential for errors.
You can read more about this in the pnpm documentation.
| "koishi-plugin-chatluna": "^1.3.7" | |
| "koishi-plugin-chatluna": "workspace:^" |
| "peerDependencies": { | ||
| "koishi": "^4.18.9", | ||
| "koishi-plugin-chatluna": "^1.3.6" | ||
| "koishi-plugin-chatluna": "^1.3.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better long-term maintainability, consider using pnpm's workspace: protocol to manage internal dependencies within this monorepo. This would automate the process of updating versions across packages.
By using "koishi-plugin-chatluna": "workspace:^" here and applying this pattern across all packages, pnpm will automatically replace workspace:^ with the correct version from the workspace (e.g., ^1.3.7) when you publish the packages. This eliminates the need for manual updates in PRs like this one, reducing maintenance overhead and the potential for errors.
You can read more about this in the pnpm documentation.
| "koishi-plugin-chatluna": "^1.3.7" | |
| "koishi-plugin-chatluna": "workspace:^" |
| "peerDependencies": { | ||
| "koishi": "^4.18.9", | ||
| "koishi-plugin-chatluna": "^1.3.6" | ||
| "koishi-plugin-chatluna": "^1.3.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better long-term maintainability, consider using pnpm's workspace: protocol to manage internal dependencies within this monorepo. This would automate the process of updating versions across packages.
By using "koishi-plugin-chatluna": "workspace:^" here and applying this pattern across all packages, pnpm will automatically replace workspace:^ with the correct version from the workspace (e.g., ^1.3.7) when you publish the packages. This eliminates the need for manual updates in PRs like this one, reducing maintenance overhead and the potential for errors.
You can read more about this in the pnpm documentation.
| "koishi-plugin-chatluna": "^1.3.7" | |
| "koishi-plugin-chatluna": "workspace:^" |
| "peerDependencies": { | ||
| "koishi": "^4.18.9", | ||
| "koishi-plugin-chatluna": "^1.3.6" | ||
| "koishi-plugin-chatluna": "^1.3.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better long-term maintainability, consider using pnpm's workspace: protocol to manage internal dependencies within this monorepo. This would automate the process of updating versions across packages.
By using "koishi-plugin-chatluna": "workspace:^" here and applying this pattern across all packages, pnpm will automatically replace workspace:^ with the correct version from the workspace (e.g., ^1.3.7) when you publish the packages. This eliminates the need for manual updates in PRs like this one, reducing maintenance overhead and the potential for errors.
You can read more about this in the pnpm documentation.
| "koishi-plugin-chatluna": "^1.3.7" | |
| "koishi-plugin-chatluna": "workspace:^" |
| "peerDependencies": { | ||
| "koishi": "^4.18.9", | ||
| "koishi-plugin-chatluna": "^1.3.6" | ||
| "koishi-plugin-chatluna": "^1.3.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better long-term maintainability, consider using pnpm's workspace: protocol to manage internal dependencies within this monorepo. This would automate the process of updating versions across packages.
By using "koishi-plugin-chatluna": "workspace:^" here and applying this pattern across all packages, pnpm will automatically replace workspace:^ with the correct version from the workspace (e.g., ^1.3.7) when you publish the packages. This eliminates the need for manual updates in PRs like this one, reducing maintenance overhead and the potential for errors.
You can read more about this in the pnpm documentation.
| "koishi-plugin-chatluna": "^1.3.7" | |
| "koishi-plugin-chatluna": "workspace:^" |
| "peerDependencies": { | ||
| "koishi": "^4.18.9", | ||
| "koishi-plugin-chatluna": "^1.3.6" | ||
| "koishi-plugin-chatluna": "^1.3.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better long-term maintainability, consider using pnpm's workspace: protocol to manage internal dependencies within this monorepo. This would automate the process of updating versions across packages.
By using "koishi-plugin-chatluna": "workspace:^" here and applying this pattern across all packages, pnpm will automatically replace workspace:^ with the correct version from the workspace (e.g., ^1.3.7) when you publish the packages. This eliminates the need for manual updates in PRs like this one, reducing maintenance overhead and the potential for errors.
You can read more about this in the pnpm documentation.
| "koishi-plugin-chatluna": "^1.3.7" | |
| "koishi-plugin-chatluna": "workspace:^" |
| "faiss-node": "^0.5.1", | ||
| "koishi": "^4.18.9", | ||
| "koishi-plugin-chatluna": "^1.3.6" | ||
| "koishi-plugin-chatluna": "^1.3.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better long-term maintainability, consider using pnpm's workspace: protocol to manage internal dependencies within this monorepo. This would automate the process of updating versions across packages.
By using "koishi-plugin-chatluna": "workspace:^" here and applying this pattern across all packages, pnpm will automatically replace workspace:^ with the correct version from the workspace (e.g., ^1.3.7) when you publish the packages. This eliminates the need for manual updates in PRs like this one, reducing maintenance overhead and the potential for errors.
You can read more about this in the pnpm documentation.
| "koishi-plugin-chatluna": "^1.3.7" | |
| "koishi-plugin-chatluna": "workspace:^" |
| "peerDependencies": { | ||
| "koishi": "^4.18.9", | ||
| "koishi-plugin-chatluna": "^1.3.6" | ||
| "koishi-plugin-chatluna": "^1.3.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better long-term maintainability, consider using pnpm's workspace: protocol to manage internal dependencies within this monorepo. This would automate the process of updating versions across packages.
By using "koishi-plugin-chatluna": "workspace:^" here and applying this pattern across all packages, pnpm will automatically replace workspace:^ with the correct version from the workspace (e.g., ^1.3.7) when you publish the packages. This eliminates the need for manual updates in PRs like this one, reducing maintenance overhead and the potential for errors.
You can read more about this in the pnpm documentation.
| "koishi-plugin-chatluna": "^1.3.7" | |
| "koishi-plugin-chatluna": "workspace:^" |
This pr bumps the version of
koishi-plugin-chatlunaand its related packages to 1.3.7.New Features
None
Bug fixes
None
Other Changes
packages/core/package.json^1.3.7across all adapter, extension, service, and renderer packages.