chore(release): bump version to 1.3.6 #666
Conversation
|
Caution Review failedThe pull request is closed. 总体概述在 LunaDBVectorStore.delete 方法中移除了运行时验证逻辑。之前的实现会检查请求的 ID 是否存在，现在跳过了这些检查，直接对提供的 ID 进行删除操作。 变更内容
代码审查工作量估估🎯 2 (简单) | ⏱️ ~8 分钟 庆祝诗
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (26)
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @dingyi222666, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on a routine version update, bumping the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://waps.l3s.uni-hannover.de/live/im_/https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request primarily consists of version bumps for a new release, which is standard procedure. However, I have a significant concern about the change in packages/service-vector-store/src/vectorstore/base/lunavdb.ts, where validation logic for document deletion has been commented out. This change silences errors when attempting to delete non-existent documents, which can hide bugs and make debugging more difficult. I've added a detailed comment explaining my concerns and providing an example of how to restore the safer behavior.
| // const mappingIds = Array.from(this.docstore._docs.keys()) | ||
|
|
||
| const missingIds = documentIds.filter((id) => !mappingIds.includes(id)) | ||
|
|
||
| if (missingIds.length > 0) { | ||
| throw new Error( | ||
| `Some specified documentIds do not exist in the current store. DocumentIds not found: ${Array.from( | ||
| missingIds | ||
| ).join(', ')}` | ||
| ) | ||
| } | ||
| // const missingIds = documentIds.filter((id) => !mappingIds.includes(id)) |
There was a problem hiding this comment.
Commenting out this validation logic makes the delete operation more lenient, but it also introduces risks by hiding potential bugs. If a caller attempts to delete a document ID that doesn't exist, the operation will now silently pass, whereas before it would throw an error. This can mask problems in the calling logic and lead to a difficult-to-debug inconsistent state.
I recommend re-instating the validation that throws an error for non-existent IDs. If making the deletion idempotent is a requirement, a safer approach would be to explicitly check for existence and log a warning for missing IDs instead of throwing an error. Simply removing the check is risky.
For example, you could restore the previous logic:
const mappingIds = Array.from(this.docstore._docs.keys())
const missingIds = documentIds.filter((id) => !mappingIds.includes(id))
if (missingIds.length > 0) {
throw new Error(
`Some specified documentIds do not exist in the current store. DocumentIds not found: ${Array.from(
missingIds
).join(', ')}`
)
}
This PR bumps the version of chatluna and its packages to 1.3.6.
New Features
Bug fixes
Other Changes
packages/service-vector-store/src/vectorstore/base/lunavdb.ts.