-
-
Notifications
You must be signed in to change notification settings - Fork 41
[Fix] Standardize modelMaxContextSize handling and bump versions #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…apters - Extract modelMaxContextSize calculation to a consistent pattern - Use getModelMaxContextSize helper where available - Ensure fallback to 128_000 tokens when maxTokens is undefined - Apply consistent calculation for maxTokenLimit across all adapters - Remove unused logger import from EMGAS extractor This ensures all adapters handle context size limits uniformly and prevents potential issues with undefined maxTokens values.
Update package versions across all adapters, extensions, and services: - Core: 1.3.0-alpha.75 -> 1.3.0-alpha.76 - Shared adapter: 1.0.14 -> 1.0.15 - All adapter packages updated to reference new core and shared-adapter versions - Extension and service packages updated with new core peer dependency This version bump follows the previous fix for modelMaxContextSize handling.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⛔ Files ignored due to path filters (26)
📒 Files selected for processing (10)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @dingyi222666, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the robustness and consistency of context window management within the system's various model adapters. It ensures that all adapters correctly interpret and apply Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively standardizes modelMaxContextSize handling across various adapters and bumps package versions. The changes are a good step towards consistency. However, I've identified a few areas where the implementation can be improved for clarity, correctness, and to prevent potential runtime issues. Specifically, I've pointed out a potential bug in the claude adapter's token limit calculation and suggested refactoring in other adapters to handle potentially undefined values for modelMaxContextSize more safely and clearly. Applying these suggestions will enhance the robustness and maintainability of the codebase.
This PR fixes inconsistent modelMaxContextSize handling across adapters and bumps package versions.
Bug Fixes
Other Changes