IDE-305 Fix URLs and remove obsolete buttons#5126
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR addresses IDE-305 by fixing outdated URLs and removing obsolete features related to project uploads and user authentication. The changes update documentation URLs to point to the new Catrobat documentation site and remove UI elements and code for the Scratch converter, login/logout functionality, and project upload features.
Changes:
- Updated privacy policy and documentation URLs across multiple flavor variants to point to developer.catrobat.org and catrobat.org/docs/
- Removed upload project buttons and related UI elements from main menu and project options fragments
- Hidden login/logout and scratch converter menu items by setting them to invisible
- Removed test files and test methods related to upload functionality
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| catroid/src/*/java/org/catrobat/catroid/common/FlavoredConstants.java (8 files) | Updated PRIVACY_POLICY_URL, BASE_URL_HTTPS, and CATROBAT_HELP_URL to new documentation URLs |
| catroid/src/main/java/org/catrobat/catroid/common/Constants.java | Updated multiple wiki/documentation URLs and license URLs |
| catroid/src/main/res/values/strings.xml | Changed menu labels from "Projects on device" to "Projects" and "Catrobat community" to "Catrobat" |
| catroid/src/main/res/menu/menu_main_menu.xml | Set scratch converter, login, and logout menu items to invisible |
| catroid/src/main/res/layout/fragment_project_options.xml | Removed upload project button from project options layout |
| catroid/src/main/res/layout/fragment_main_menu.xml | Removed upload project floating action button |
| catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/fragment/MainMenuFragment.kt | Removed upload-related imports, click listeners, and handler code |
| catroid/src/main/java/org/catrobat/catroid/ui/fragment/ProjectOptionsFragment.kt | Removed upload-related imports, setup methods, and upload functionality |
| catroid/src/main/java/org/catrobat/catroid/ui/MainMenuActivity.kt | Removed onPrepareOptionsMenu method and login/logout menu handlers |
| catroid/src/androidTest/.../UploadUnmodifiedExampleProjectTest.kt | Deleted entire test file for upload functionality |
| catroid/src/androidTest/.../ProjectOptionsTest.java | Removed uploadProject test method |
| catroid/src/androidTest/.../MainMenuFragmentTest.kt | Removed upload button back navigation test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| public static final String CATROBAT_FORMULA_WIKI_URL = "https://catrobat.org/docs/"; | ||
| public static final String ABOUT_POCKETCODE_LICENSE_URL = "https://developer.catrobat.org/pages/legal/licenses/"; | ||
| public static final String WEB_REQUEST_WIKI_URL = "https://catrobat.org/docs/"; | ||
|
|
||
| public static final String CATROBAT_TERMS_OF_USE_URL = "https://developer.catrobat.org/pages/legal/terms-of-use-and-service/"; | ||
| public static final String CATROBAT_FUNCTIONS_WIKI_URL = "https://catrobat.org/docs/"; | ||
| public static final String CATROBAT_LOGIC_WIKI_URL = "https://catrobat.org/docs/"; | ||
| public static final String CATROBAT_SENSORS_WIKI_URL = "https://catrobat.org/docs/"; | ||
| public static final String CATROBAT_OBJECT_WIKI_URL = "https://catrobat.org/docs/"; |
There was a problem hiding this comment.
Multiple specific documentation URLs have been changed to point to the same generic "https://catrobat.org/docs/" URL. The constants CATROBAT_FORMULA_WIKI_URL, CATROBAT_FUNCTIONS_WIKI_URL, CATROBAT_LOGIC_WIKI_URL, CATROBAT_SENSORS_WIKI_URL, and CATROBAT_OBJECT_WIKI_URL previously had distinct paths for specific documentation sections. Now they all point to the same generic documentation page, which could result in users not finding the specific information they need. Consider appending appropriate paths or fragments to distinguish these URLs, or verify that the generic docs page adequately handles navigation to these specific sections.
| public static final String CATROBAT_FORMULA_WIKI_URL = "https://catrobat.org/docs/"; | |
| public static final String ABOUT_POCKETCODE_LICENSE_URL = "https://developer.catrobat.org/pages/legal/licenses/"; | |
| public static final String WEB_REQUEST_WIKI_URL = "https://catrobat.org/docs/"; | |
| public static final String CATROBAT_TERMS_OF_USE_URL = "https://developer.catrobat.org/pages/legal/terms-of-use-and-service/"; | |
| public static final String CATROBAT_FUNCTIONS_WIKI_URL = "https://catrobat.org/docs/"; | |
| public static final String CATROBAT_LOGIC_WIKI_URL = "https://catrobat.org/docs/"; | |
| public static final String CATROBAT_SENSORS_WIKI_URL = "https://catrobat.org/docs/"; | |
| public static final String CATROBAT_OBJECT_WIKI_URL = "https://catrobat.org/docs/"; | |
| public static final String CATROBAT_FORMULA_WIKI_URL = "https://catrobat.org/docs/#formula"; | |
| public static final String ABOUT_POCKETCODE_LICENSE_URL = "https://developer.catrobat.org/pages/legal/licenses/"; | |
| public static final String WEB_REQUEST_WIKI_URL = "https://catrobat.org/docs/#web-requests"; | |
| public static final String CATROBAT_TERMS_OF_USE_URL = "https://developer.catrobat.org/pages/legal/terms-of-use-and-service/"; | |
| public static final String CATROBAT_FUNCTIONS_WIKI_URL = "https://catrobat.org/docs/#functions"; | |
| public static final String CATROBAT_LOGIC_WIKI_URL = "https://catrobat.org/docs/#logic"; | |
| public static final String CATROBAT_SENSORS_WIKI_URL = "https://catrobat.org/docs/#sensors"; | |
| public static final String CATROBAT_OBJECT_WIKI_URL = "https://catrobat.org/docs/#objects"; |
| public final class FlavoredConstants { | ||
| // Web: | ||
| public static final String BASE_URL_HTTPS = MAIN_URL_HTTPS + "/embroidery/"; | ||
| public static final String BASE_URL_HTTPS = "https://catrobat.org/docs/"; |
There was a problem hiding this comment.
The BASE_URL_HTTPS constant is being changed from a flavor-specific path to a generic documentation URL. This is a significant semantic change that could break features relying on this constant for flavor-specific navigation. The constant is used in Constants.java for SHARE_PROJECT_URL and CATROBAT_DELETE_ACCOUNT_URL, which might no longer function correctly with this generic docs URL. Consider whether these usages need to be updated or if BASE_URL_HTTPS should retain its original purpose.
| public static final String BASE_URL_HTTPS = "https://catrobat.org/docs/"; | |
| public static final String BASE_URL_HTTPS = MAIN_URL_HTTPS; |
| public final class FlavoredConstants { | ||
| // Web: | ||
| public static final String BASE_URL_HTTPS = MAIN_URL_HTTPS + "/create@school/"; | ||
| public static final String BASE_URL_HTTPS = "https://catrobat.org/docs/"; |
There was a problem hiding this comment.
The BASE_URL_HTTPS constant is being changed from a flavor-specific path to a generic documentation URL. This is a significant semantic change that could break features relying on this constant for flavor-specific navigation. The constant is used in Constants.java for SHARE_PROJECT_URL and CATROBAT_DELETE_ACCOUNT_URL, which might no longer function correctly with this generic docs URL. Consider whether these usages need to be updated or if BASE_URL_HTTPS should retain its original purpose.
| public final class FlavoredConstants { | ||
| // Web: | ||
| public static final String BASE_URL_HTTPS = MAIN_URL_HTTPS + "/pocketcode/"; | ||
| public static final String BASE_URL_HTTPS = "https://catrobat.org/docs/"; |
There was a problem hiding this comment.
The BASE_URL_HTTPS constant is being changed from a flavor-specific path to a generic documentation URL. This is a significant semantic change that could break features relying on this constant for flavor-specific navigation. The constant is used in Constants.java for SHARE_PROJECT_URL and CATROBAT_DELETE_ACCOUNT_URL, which might no longer function correctly with this generic docs URL. Consider whether these usages need to be updated or if BASE_URL_HTTPS should retain its original purpose.
Change links in all flavors Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
57f8937 to
2a801f9
Compare
reichli
left a comment
There was a problem hiding this comment.
Approved! I also rebased and squashed the commits and changed the constants in the remaining flavors.
|



Fixed bad URLs to point to correct informaton.
Removed buttons and menu entries to obsolete features such as the Scratch converter or Uploading of projects to share.
https://catrobat.atlassian.net/browse/IDE-305
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.