Merged
Conversation
…s. Now returns 401 instead of 200.
…y/catch in case of an error.
bnookala
requested changes
Nov 15, 2018
Member
bnookala
left a comment
bnookala
left a comment
There was a problem hiding this comment.
one small nitpick but otherwise looking great!
| @@ -0,0 +1,53 @@ | |||
| import os | |||
| import logging | |||
| from azure.storage.blob import BlockBlobService | |||
Member
There was a problem hiding this comment.
this import is un-necessary, since you're not creating a new instance in this module - just being passed one
bnookala
approved these changes
Nov 15, 2018
ghost
deleted the
bnookala
pushed a commit
to bnookala/active-learning-detect
that referenced
this pull request
Dec 19, 2018
* Added exception handling for copy/delete blob operations. * Added exception handling for connection database. * Separated out blob manipulation code into a module * Dependency injection refactor. Renamed blob manipulation module and function. * Changes * Fixed return status code for when an image copy/delete operation fails. Now returns 401 instead of 200. * Wrapped code to build image object list into a function, and added try/catch in case of an error. * Code cleanup and more descriptive comments. * PR comment - deleted unnecessary module import.
abfleishman
pushed a commit
to abfleishman/active-learning-detect
that referenced
this pull request
Oct 10, 2019
Adding CLI operation stubs and tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.