Skip to content

Conversation

@Hanmac
Copy link
Contributor

@Hanmac Hanmac commented Jan 19, 2026

Part of #8682

This adds the basic land type to ColorEnum
to be used for later changes

@Jetz72
Copy link
Contributor

Jetz72 commented Jan 19, 2026

Perhaps call the field "basicLandType" if Colorless doesn't point to Wastes? Might make sense at some point to split some of these constructor parameters out to EnumMaps. The signature is getting a little cluttered.

@fediazgon
Copy link
Contributor

Is there any rationale with not making these enums? There are a bunch of places in the code where we do things like:

saMana.hasParam("ReplaceOnly")

where this could have been an enum. If you need a display name, you can also do:

public enum BasicLandType {
    PLAINS("Plains"),
    ISLAND("Island"),
    SWAMP("Swamp"),
    MOUNTAIN("Mountain"),
    FOREST("Forest");

    private final String displayName;

    BasicLandType(String displayName) {
        this.displayName = displayName;
    }

    public String getDisplayName() {
        return displayName;
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants