CDT_3: ship <tl/expected.hpp> (#9145) #9197
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the FetchContent mechanism with a vendored copy of tl/expected.hpp (v1.1.0). The header is placed in CGAL/tl/expected.hpp to avoid namespace pollution. This also removes the CMake module CGAL_setup_tl-excepted.cmake. ## Release Management * Affected package(s): Constrained_triangulation_3 * Issue(s) solved (if any): CGAL#9145 * License and copyright ownership: CC0 1.0 Universal (tl/expected.hpp)
Member
|
Thanks for the PR. I'd move the tl/expected.hpp file into |
Author
|
I added the SPDX tag to the header. I cannot run the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the
FetchContentmechanism with a vendored copy oftl/expected.hpp(v1.1.0).The header is placed in
CGAL/tl/expected.hppto avoid namespace pollution.This also removes the CMake module
CGAL_setup_tl-excepted.cmake.Release Management