Open
Conversation
Melisearch is a dependency for the frontend but isn't configured to be a healthy service before starting the web container. Melisearch lacks a health check to ensure it operates as expected. Without a health check, it could run endlessly or restart without functioning properly. Additionally, the web container lacks a defined timezone to output correct timestamps for debugging purposes.
Contributor
Author
|
|
2mal3
requested changes
Sep 1, 2024
Contributor
2mal3
left a comment
2mal3
left a comment
There was a problem hiding this comment.
Strange. The dependency condition does not seem to work. Even if the meilisearch container is already ready, the web container still does not start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Melisearch is a dependency for the frontend but isn't configured to be a healthy service before starting the web container.
Melisearch lacks a health check to ensure it operates as expected. Without a health check, it could run endlessly or restart without functioning properly.
Additionally, the web container lacks a defined timezone to output correct timestamps for debugging purposes.