Add necessary fixes to make new releases#9
Conversation
@martinalbert It's not clear to me why this is needed, could you elaborate? |
|
@Toreno96 sure, the change regarding version is required mainly due to how python module |
@martinalbert Do you mean that A loose idea, but what if we try to go extra simple and define the version inline in the |
- Add `requirements.txt` for defining required dependencies - Get version from `__version__.py` file with exec - avoiding initialization of the package prematurely - Fix typo in imported exception HTTPError from package requests
Toreno96
left a comment
There was a problem hiding this comment.
LGTM, I don't have any more comments
ViolanteCodes
left a comment
There was a problem hiding this comment.
This builds for me - I was able to setup a new environment and do a clean install and python setup.py sdist bdist_wheel without issue.
This PR adds necessary fixes to make new releases possible.
requirements.txtfor defining required dependencies (for commandpip install -r requirements.txt)__version__.pyfile with use ofexec- avoiding initialization of the package prematurelyHTTPErrorfrom packagerequests