Merged
Conversation
ViolanteCodes
requested changes
Mar 13, 2023
Contributor
ViolanteCodes
left a comment
ViolanteCodes
left a comment
There was a problem hiding this comment.
can i ask you to bump the version of the package with this PR?
Contributor
|
added @Toreno96 as reviewer post our meeting earlier, thanks :) |
Toreno96
requested changes
Mar 13, 2023
Contributor
Author
|
@Toreno96 thanks for the review, updated client |
Toreno96
reviewed
Mar 13, 2023
martinalbert
force-pushed
the
fix/handle-request-fails
branch
from
59565e8 to
17898e0
Compare
Contributor
|
@Toreno96 does this look okay to you? if so, I can ask @martinalbert to squash and i'll merge? |
@ViolanteCodes yes, LGTM! ✅ |
- add handling of timeout of 10 seconds - add check for success fix(client): review fixes chore: update version from 1.3 to 2.0 fix(client): review fixes
martinalbert
force-pushed
the
fix/handle-request-fails
branch
from
17898e0 to
ac2aa78
Compare
ViolanteCodes
approved these changes
Mar 15, 2023
Contributor
ViolanteCodes
left a comment
ViolanteCodes
left a comment
There was a problem hiding this comment.
Looks good, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5 and #6
This PR adds handling of timeout (10 seconds) and adds check for request success.