Lepton scale factors #123
Closed
Lepton scale factors #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Just remembered I was working on top of Emyr's hadronEfficiency branch, since there was an existing pull request from there, which is where all those previous commits come from. |
jjacob
force-pushed
the
lepton_scale_factors
branch
from
796e64f to
2832958
Compare
Contributor
Author
|
With Emyr's fix the warnings are now gone. I've tested on soolin, output files are in /storage/phjaj/02_Analysis/CMSSW_6_2_0_pre6_AnalysisSoftware/src/testing_lepton_scale_factors, if you want to check outputs. I think this is ready to merge. |
Member
There was a problem hiding this comment.
OK, two things:
- why do you need to store (copy the pointer) of a global histogram for every electron for every event?
- why doesn't the private variable end with '_'?
Member
|
While I would not merge it before making some improvements I think it is safe to run. |
Member
|
rebase please |
jjacob
added a commit
to jjacob/AnalysisSoftware
that referenced
this pull request
Dec 17, 2014
Contributor
Author
|
Made new pull request (#127) so closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the (mostly) finished update to read 7TeV electron scale factors from histogram files.
Compiles and runs, but during running there are some warnings of memory leaks related to TEfficiency, which I was unable to solve...hence WIP.
Also, will remove the couts once this is ready to merge.