Skip to content

Conversation

@kreczko
Copy link
Member

@kreczko kreczko commented Aug 26, 2014

  • added travis setup files
  • added caching for ROOT installation
  • tidied up CMakeLists.txt to have a clear separation between OS X and Ubuntu for a few flags
  • added CMake script to test STL containers
    The latter fails on OS X as is documented in issue Compilation problem with CMake on OS X #115

@kreczko
Copy link
Member Author

kreczko commented Aug 26, 2014

The travis build is now working for clang and failing for g++ due to the command line option -stdlib=libstdc++. So cmake has to be intelligent enough to distinguish between the two.

@kreczko kreczko changed the title [WIP] Travis setup Travis setup Aug 28, 2014
@kreczko
Copy link
Member Author

kreczko commented Aug 28, 2014

Ready for merge.

@senkin
Copy link
Member

senkin commented Aug 28, 2014

Nice one! So the next step would be implementing tests for all features we have?

@kreczko
Copy link
Member Author

kreczko commented Aug 28, 2014

Since we want to get rid of AS at some point I would say that only the most important tests should be transferred. As we've recently seen 'b-tag weights' would be a good example for it.
Suggestions are welcome.

senkin added a commit that referenced this pull request Aug 28, 2014
@senkin senkin merged commit c83491f into BristolTopGroup:master Aug 28, 2014
@kreczko kreczko deleted the travis-setup branch January 19, 2015 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants