Skip to content

fix melee hit talents being counted twice in TBC #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BreakBB merged 2 commits into from
Feb 18, 2026
Merged

fix melee hit talents being counted twice in TBC #425

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e509126
fix melee hit talents being counted twice in TBC
Alessandro-Barbieri Feb 18, 2026
1a7f677
typo
Alessandro-Barbieri Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions Modules/Data/Melee.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,18 +75,15 @@ function _Melee:GetHitTalentBonus()
if Data:GetMeleeAttackSpeedOffHand() > 0 then
mod = 2 * DataUtils:GetActiveTalentSpell({30816,30818,30819})
end
else
elseif ECS.IsClassic then
-- Nature's Guidance
mod = 1 * DataUtils:GetActiveTalentSpell({16180,16196,16198})
end
elseif classId == Data.PALADIN then
if ECS.IsTBC then
elseif classId == Data.ROGUE then
if ECS.IsClassic then
-- precision
mod = 1 * DataUtils:GetActiveTalentSpell({20189,20192,20193})
mod = 1 * DataUtils:GetActiveTalentSpell({13705,13832,13843,13844,13845})
end
elseif classId == Data.ROGUE then
-- precision
mod = 1 * DataUtils:GetActiveTalentSpell({13705,13832,13843,13844,13845})
elseif classId == Data.DEATHKNIGHT then
-- Nerves of Cold Steel
-- This assumes a DK is dual wielding and not only using a one-hand main hand weapon
Expand Down
Loading