feat: Allow usage of custom http client#95
Open
titouanfreville wants to merge 3 commits intoBlazemeter:masterfrom
Open
feat: Allow usage of custom http client#95titouanfreville wants to merge 3 commits intoBlazemeter:masterfrom
titouanfreville wants to merge 3 commits intoBlazemeter:masterfrom
Conversation
* Add an HTTP class where client is configurable * Make old `http` class as `HTTP()` default instance using `requests` client * Add a single test case to ensure basic assertion works with custom client
# Wrap at 72 chars. ################################## which is here: # # type: # fix -> change that do not modify fonctional code but fix an issue # feat -> code introduce a new feature # refactor -> change that only modify code without introducing feature nor solving bug # perf -> change that optimize performance # test -> modification impacting testing only # ci -> modification on ci # docs -> doc update # # scope: feature impacted by the changes # # append ! if change is breaking # cf: https://www.conventionalcommits.org/en/v1.0.0/ for more information # ###### COMMIT SAMPLE ################################################### # feat(HOOKS): Add commit hooks style validation # # To ensure all of Tankyou dev follow commit rules, we wish to enforce # commit content using commit-msg hook # This hook will be configured to be installed globally and will be # triggered on each repository ######################################################################## # # Title: Summary, imperative, start upper case, don't end with a period (.) # # Remember blank line between title and body. # # Body: Explain *what* and *why* (not *how*). # # # How to Write a Git Commit Message: # https://chris.beams.io/posts/git-commit/ # # 1.Separate subject from body with a blank line # 2. Limit the subject line to 50 characters # 3. Capitalize the subject line # 4. Do not end the subject line with a period # 5. Use the imperative mood in the subject line # 6. Wrap the body at 72 characters # 7. Use the body to explain what and why vs. how # # Footer: # - BREAKING CHANGE: indicate what change are breaking the API and why
titouanfreville
force-pushed
the
master
branch
from
1fa3700 to
ce8fcb4
Compare
titouanfreville
force-pushed
the
master
branch
from
ce8fcb4 to
e81fd58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
httpclass asHTTP()default instance usingrequestsclient