Implement tests for SQLNumResultCols #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jduo
reviewed
Jul 29, 2025
alinaliBQ
reviewed
Jul 29, 2025
cpp/src/arrow/flight/sql/odbc/odbcabstraction/odbc_impl/odbc_statement.cc
Show resolved
Hide resolved
Comment on lines
2403
to
2410
| TEST_F(FlightSQLODBCMockTestBase, SQLNumResultColsReturnsColumnsOnSelect) { | ||
| this->connect(); | ||
| this->CreateTestTables(); | ||
|
|
||
| SQLSMALLINT columnCount = 0; | ||
| SQLSMALLINT expectedValue = 3; | ||
| SQLWCHAR sqlQuery[] = L"SELECT * FROM TestTable LIMIT 1;"; | ||
| SQLINTEGER queryLength = static_cast<SQLINTEGER>(wcslen(sqlQuery)); |
There was a problem hiding this comment.
Similar to SQLRowCount, let's run the test on both remote and mock server
jduo
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement test cases for SQLNumResultCols