Update dependencies #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshschriever
commented
May 7, 2021
Comment on lines
+48
to
+50
| withTimeoutOrNull(timeoutMillis) { | ||
| deferred.await() | ||
| } ?: AdbTimeoutException().left() |
Collaborator
Author
There was a problem hiding this comment.
For the most part, this works the same as before, but we're now using Left with a specific exception type for timeout, instead of Right with null.
| FlagParser().parse( | ||
| *listOfNotNull( | ||
| "install-apks", | ||
| "--timeout-millis=$timeoutMillis", |
Collaborator
Author
There was a problem hiding this comment.
The new bundletool version added this flag, so we can let it handle timeout itself now, instead of wrapping this in the coroutine timeout stuff.
Comment on lines
+35
to
+38
| is AdbTimeoutException -> { | ||
| logger.error("$progress -> ${device.serial}: ${test.classAndMethodName}: TIMED OUT") | ||
| TestResult.Failed(null, "Test timed out", device.serial) | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Behavior should be exactly the same as before, we're just doing it by checking for the AdbTimeoutException instead of checking for null on the Right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥅 What is the goal?
💻 How is it implemented?
This should be mostly done, but I'm still testing all the cases