Skip to content

Clean includes#3226

Merged
ronghanghu merged 2 commits intoBVLC:masterfrom
kkhoot:clean_header
Oct 22, 2015
Merged

Clean includes#3226
ronghanghu merged 2 commits intoBVLC:masterfrom
kkhoot:clean_header

Conversation

@kkhoot
Copy link
Copy Markdown
Contributor

@kkhoot kkhoot commented Oct 20, 2015

This PR reduces header includes to speed up (partial) builds.

  1. Give appropriate subcategory layer headers to each layer/test file.
    Most of the layers/tests include the monolithic header vision_layers.hpp which causes recompiling almost all layer/test cpps when changes in other subcategory layer headers (such as common_layers.hpp, etc.) are made.
  2. Remove unnecessary headers
    Many of the files include unneeded headers (such as cstring). Most of these includes were erased.

-During this work, I found that HDF5 defines are defined in a different layer header, so moved it to the right place.

@kkhoot kkhoot changed the title Clean headers Clean includes Oct 20, 2015
@ronghanghu ronghanghu self-assigned this Oct 21, 2015
@ronghanghu
Copy link
Copy Markdown
Member

@kkhoot Thanks for the header cleanup! I'll try to review tonight or tomorrow.

ronghanghu added a commit that referenced this pull request Oct 22, 2015
@ronghanghu ronghanghu merged commit 20c474f into BVLC:master Oct 22, 2015
@ronghanghu
Copy link
Copy Markdown
Member

The headers seem much cleaner after this PR. Thanks again @kkhoot

@shelhamer
Copy link
Copy Markdown
Member

Thanks for this @kkhoot. This is a nice reform and a step in the direction of #1646.

@kkhoot
Copy link
Copy Markdown
Contributor Author

kkhoot commented Oct 22, 2015

@ronghanghu @shelhamer Thanks for quick review :)

@kkhoot kkhoot deleted the clean_header branch October 22, 2015 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants