Merged
Conversation
Member
|
@kkhoot Thanks for the header cleanup! I'll try to review tonight or tomorrow. |
Member
|
The headers seem much cleaner after this PR. Thanks again @kkhoot |
Member
Contributor
Author
|
@ronghanghu @shelhamer Thanks for quick review :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces header includes to speed up (partial) builds.
Most of the layers/tests include the monolithic header vision_layers.hpp which causes recompiling almost all layer/test cpps when changes in other subcategory layer headers (such as common_layers.hpp, etc.) are made.
Many of the files include unneeded headers (such as cstring). Most of these includes were erased.
-During this work, I found that HDF5 defines are defined in a different layer header, so moved it to the right place.