Endpoint fixes

[Ryanmeakins]

Problem: The provider base class does not return any values for resource types or schemas. Therefore running the sample as is with the InMemory provider returns empty arrays when calling the endpoints.
Solution: In order to increase the usefulness of the sample provider sample values have been added to the returned collection for Types and Schemas.
Validation: The included Postman tests for endpoint validation.

[mllab-nl]

Good PR @Ryanmeakins
@ArvindHarinder1 Any reason it is not being merged ?

[peteretelej]

Approving to unblock, since payload matches spec. I think this endpoint also requires Auth (at the moment accessible without auth).

Also, the /Schemas endpoint should list all attributes supported by the endpoint ( see RFC here)

An HTTP GET to the endpoint "/Schemas" SHALL return all supported schemas in ListResponse format

A few attributes are missing from those supported by this scim app. For example for User resource: nickName, timezone, roles, and some subattributes eg in name.

[peteretelej]

The Name attribute in this endpoint supports other subattributes (eg FamilyName, HonorificPrefix, HonorificSuffix) but are not added here hence not returned in /Schemas (see here). /Schemas should include all supported attributes / subattributes of the scim endpoint

[ArvindHarinder1]

+1 the attributes returned should match what the API supports.

[blairno]

The latest version of this branch returns an empty "schemas" array when creating a new user.
For example, using the following payload to POST a new User resource:
{ "UserName": "UserName222", "Active": true, "DisplayName": "lennay", "schemas": [ "urn:ietf:params:scim:schemas:extension:enterprise:2.0:User", "urn:ietf:params:scim:schemas:core:2.0:User" ], "externalId": "${__UUID}", "name": { "formatted": "Adrew Ryan", "familyName": "Ryan", "givenName": "Andrew" }, "emails": [ { "Primary": true, "type": "work", "value": "testing@bob2.com" }, { "Primary": false, "type": "home", "value": "testinghome@bob3.com" } ], "urn:ietf:params:scim:schemas:extension:enterprise:2.0:User": { "Department": "bob", "Manager" : { "Value": "SuzzyQ" } } }

The returned response is as follows (the "schemas" attribute is an empty array).
{ "urn:ietf:params:scim:schemas:extension:enterprise:2.0:User": { "manager": { "value": "SuzzyQ" }, "department": "bob" }, "active": true, "displayName": "lennay", "emails": [ { "type": "work", "primary": true, "value": "testing@bob2.com" }, { "type": "home", "primary": false, "value": "testinghome@bob3.com" } ], "meta": { "resourceType": "User" }, "name": { "formatted": "Adrew Ryan", "familyName": "Ryan", "givenName": "Andrew" }, "userName": "UserName222", "externalId": "${__UUID}", "id": "13b49587-4efd-46ad-af94-ee9f54874fda", "schemas": [] }

This does not happen with the Master branch, which correctly returns the expected array of "schemas".

Reversing the 2 line change in "Microsoft.SystemForCrossDomainIdentityManagement/Schemas/Schematized.cs" seems to fix that issue on my machine, but I am not sure what else that might impact or what the original purpose of that change was.

I think the issue is that in the change the "IReadOnlyCollection Schemas" field is being decorated as the DataMember named "Schemas" which returns an empty array when it is serialized into json since I don't think "IReadOnlyCollection" supports serialization.
Prior to the change, the "List schemas" field was decorated as the DataMember named "Schemas" which is able to be successfully serialized.
^^^ @charitymarani

[charitymarani]

The latest version of this branch returns an empty "schemas" array when creating a new user.
For example, using the following payload to POST a new User resource:
{ "UserName": "UserName222", "Active": true, "DisplayName": "lennay", "schemas": [ "urn:ietf:params:scim:schemas:extension:enterprise:2.0:User", "urn:ietf:params:scim:schemas:core:2.0:User" ], "externalId": "${__UUID}", "name": { "formatted": "Adrew Ryan", "familyName": "Ryan", "givenName": "Andrew" }, "emails": [ { "Primary": true, "type": "work", "value": "testing@bob2.com" }, { "Primary": false, "type": "home", "value": "testinghome@bob3.com" } ], "urn:ietf:params:scim:schemas:extension:enterprise:2.0:User": { "Department": "bob", "Manager" : { "Value": "SuzzyQ" } } }

The returned response is as follows (the "schemas" attribute is an empty array).
{ "urn:ietf:params:scim:schemas:extension:enterprise:2.0:User": { "manager": { "value": "SuzzyQ" }, "department": "bob" }, "active": true, "displayName": "lennay", "emails": [ { "type": "work", "primary": true, "value": "testing@bob2.com" }, { "type": "home", "primary": false, "value": "testinghome@bob3.com" } ], "meta": { "resourceType": "User" }, "name": { "formatted": "Adrew Ryan", "familyName": "Ryan", "givenName": "Andrew" }, "userName": "UserName222", "externalId": "${__UUID}", "id": "13b49587-4efd-46ad-af94-ee9f54874fda", "schemas": [] }

This does not happen with the Master branch, which correctly returns the expected array of "schemas".

Reversing the 2 line change in "Microsoft.SystemForCrossDomainIdentityManagement/Schemas/Schematized.cs" seems to fix that issue on my machine, but I am not sure what else that might impact or what the original purpose of that change was.

I think the issue is that in the change the "IReadOnlyCollection Schemas" field is being decorated as the DataMember named "Schemas" which returns an empty array when it is serialized into json since I don't think "IReadOnlyCollection" supports serialization.
Prior to the change, the "List schemas" field was decorated as the DataMember named "Schemas" which is able to be successfully serialized.
^^^ @charitymarani

@blairno I just confirmed the issue. Thank you for noticing. I have pushed new changes