Skip to content

{Auth} Enable PII log for WAM #28954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 1 commit into from
Apr 8, 2025
Merged

{Auth} Enable PII log for WAM #28954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/azure-cli-core/azure/cli/core/auth/identity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,9 @@ def _msal_app_kwargs(self):
def _msal_public_app_kwargs(self):
"""kwargs for creating PublicClientApplication."""
# enable_broker_on_windows can only be used on PublicClientApplication.
return {**self._msal_app_kwargs, "enable_broker_on_windows": self._enable_broker_on_windows}
return {**self._msal_app_kwargs,
"enable_broker_on_windows": self._enable_broker_on_windows,
"enable_pii_log": True}
Copy link
Member

@evelyn-ys evelyn-ys Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I know why not adding this to _msal_app_kwargs?

Copy link
Member Author

@jiasli jiasli Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable_pii_log only affects the WAM flow from PublicClientApplication:

If adding enable_pii_log to _msal_app_kwargs, it will be passed to ConfidentialClientApplication which doesn't support WAM at all.

https://github.com/AzureAD/microsoft-authentication-library-for-python/blob/30dce4ecc63d93ef34b89c052aab1a1231395ce6/msal/application.py#L660

        self._decide_broker(allow_broker, enable_pii_log)

https://github.com/AzureAD/microsoft-authentication-library-for-python/blob/30dce4ecc63d93ef34b89c052aab1a1231395ce6/msal/application.py#L675-L676

    def _decide_broker(self, allow_broker, enable_pii_log):
        is_confidential_app = self.client_credential or isinstance(
            self, ConfidentialClientApplication)
        if is_confidential_app and allow_broker:
            raise ValueError("allow_broker=True is only supported in PublicClientApplication")


@property
def _msal_app(self):
Expand Down