This repository was archived by the owner on Feb 3, 2021. It is now read-only.
Feature/custom script #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paselem, |
paselem
commented
Jun 14, 2017
|
|
||
| if args.custom_script is not None: | ||
| _custom_script = args.custom_script | ||
| print("path to custom script: %s" % _custom_script) |
Contributor
Author
There was a problem hiding this comment.
minor: going forward I usually prefer print('foo {}'.format('myString')). Do you have an opinion?
paselem
commented
Jun 14, 2017
| clusterlib.create_cluster( | ||
| batch_client, | ||
| blob_client, | ||
| _custom_script, |
Contributor
Author
There was a problem hiding this comment.
why do some variables start with _ and not others?
paselem
commented
Jun 14, 2017
|
|
||
| run_custom_script = '' | ||
| if custom_script_file is not None: | ||
| run_custom_script = '/bin/sh -c ' + custom_script_file |
Contributor
Author
There was a problem hiding this comment.
use '/bin/sh -c {}'.format(custom_script_file)
paselem
commented
Jun 14, 2017
| def cluster_install_cmd(): | ||
| def cluster_install_cmd(custom_script_file): | ||
|
|
||
| run_custom_script = '' |
Contributor
Author
There was a problem hiding this comment.
some places use "", while other use ''. We should consolidate on one.
paselem
commented
Jun 14, 2017
Contributor
Author
paselem
left a comment
paselem
left a comment
There was a problem hiding this comment.
Please view my feedbck
Contributor
|
i will disregard your comments for this PR and create a separate work item which would be to consolidate syntax. |
Contributor
Author
jafreck
pushed a commit
to jafreck/aztk
that referenced
this pull request
Aug 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.