Open
Conversation
awmatheson
previously approved these changes
Apr 23, 2020
Contributor
awmatheson
left a comment
awmatheson
left a comment
There was a problem hiding this comment.
LGTM, we will need to build in some tests for these eventually.
Member
Author
|
added Unit Test basic one, if this format looks fine we will go ahead with that |
Contributor
|
@ashishonce this looks good, but we are going to wait to merge until we finish the integration tests across all the actions. This should be finished this week. |
Member
Author
|
@awmatheson that makes sense, but just a point. This PR is a breaking change as it changes the run.json format which is a list now. So your integrations tests will still need to update then. |
marvinbuss
requested changes
May 1, 2020
Contributor
marvinbuss
left a comment
marvinbuss
left a comment
There was a problem hiding this comment.
Before merging this:
- Add integration tests
- Describe features in Readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for supporting multiple run submissions as part of a single WF execution.
we are using multiprocessing library to process each entry here. to save the time on parallel waits for execution to complete.
currently creating a pool of processes as 8, but once we agree on this approach we can find an optimal value of processes to start.