Conversation
Replace the welcome email deep link with an HTTPS landing page that forwards all query parameters into RocketSim and falls back to the homepage when the app is not installed.
Align the new redirect page with the docs Prettier rules so the quality check passes in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/claim-offerAstro page that forwards the full incoming query string intorocketsim://open-offerWe added this page because the welcome email previously used a
rocketsim://deep link directly, and custom URL schemes are more likely to get flagged by email clients such as Outlook. Switching the email to an HTTPShttps://www.rocketsim.app/claim-offerURL preserves the same in-app offer flow while improving deliverability and still falling back gracefully when RocketSim is not installed.Test plan
cd docs && npm run buildhttp://127.0.0.1:4322/claim-offer?discount=30&code=SWIFTLEEWEEKLY&source=website_welcome_email&email=test%40example.com