You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 17, 2025. It is now read-only.
Using this PR as a place to get TT3 into a ready state for the TT3 repo.
TT3 is a stripped-back version of TT2, so I believe the general layouts should be the same/similar, and the colours and fonts should be simple and easy to customise with style variations.
So far, this PR includes:
Clone of TT2, renamed to TT3
Remove TT2's patterns
Remove TT2's dark headers (but keep every other template part)
Add TT3's base colours
Add the 3 base fonts (System Font, DM Sans, and Source Serif Pro)
Add font and heading sizes, using fluid sizes where possible
Add spacing presets (WIP)
Add the 4 additional style variations (WIP)
From a reviewing perspective, it would be great if you could check:
Have I made the correct decisions with what to include and exclude from TT2? (especially with templates and patterns)
It looks like this is because TT2 applies the following CSS globally:
body {
-moz-osx-font-smoothing: grayscale;
-webkit-font-smoothing: antialiased;
}
Initially, I was trying to avoid using CSS at all, with no style.css or functions.php file. However, the font looks so much better with this font-smoothing setting...
TT3 Hover states vs TT2 (Intended hover states)
These should be done (with no CSS!)
Text links should be #345C00 instead of #9DFF20
Done.
Buttons: Hover states don't seem to match the mockups.
Sorry, I should've mentioned that the button hover states need this GB PR to work: WordPress/gutenberg#43088
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using this PR as a place to get TT3 into a ready state for the TT3 repo.
TT3 is a stripped-back version of TT2, so I believe the general layouts should be the same/similar, and the colours and fonts should be simple and easy to customise with style variations.
So far, this PR includes:
From a reviewing perspective, it would be great if you could check: