Sync: Allow syncing WooCommerce Acounts and Privacy page options#48041
Sync: Allow syncing WooCommerce Acounts and Privacy page options#48041coder-karen wants to merge 3 commits intotrunkfrom
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
There was a problem hiding this comment.
Thanks for working on adding these options @coder-karen!
I feel that there is a missing WPCOM counterpart before these changes might have impact in WPCOM.
See some prior art with the corresponding WPCOM counterpart.
darssen
left a comment
There was a problem hiding this comment.
I feel that there is a missing WPCOM counterpart before these changes might have impact in WPCOM.
This is not totally correct since Activity Log does show the option synced, even though the cache site doesn't get the changes.
We should be consistent, but as discussed internally, we will handle WPCOM counterpart with future diffs. Unblocking this.
First part of ACTLOG-34
Proposed changes
Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
To test, on a Jetpack-connected Jetpack API sandboxed site with WooCommerce installed and active, apply this PR using the Jetpack Beta tester plugin (or apply locally).
/wp-admin/admin.php?page=wc-settings&tab=account), and toggle / change various optionsjetpack-audit*logs for your site and you should see the relevantupdated_optionactions being logged.