Skip to content

Sync: Allow syncing WooCommerce Acounts and Privacy page options#48041

Open
coder-karen wants to merge 3 commits intotrunkfrom
add/allow-sync-for-woo-accounts-privacy-options
Open

Sync: Allow syncing WooCommerce Acounts and Privacy page options#48041
coder-karen wants to merge 3 commits intotrunkfrom
add/allow-sync-for-woo-accounts-privacy-options

Conversation

@coder-karen
Copy link
Copy Markdown
Contributor

First part of ACTLOG-34

Proposed changes

  • This PR allows WooCommerce Accounts and Privacy settings page options to be synced. The intention is to then display these option changes on the Activity Log later.

Related product discussion/links

  • This is part of the project to 'Log changes to Woo options and sensitive + useful data' (see project linked to the above Linear issue).

Does this pull request change what data or activity we track or use?

No.

Testing instructions

To test, on a Jetpack-connected Jetpack API sandboxed site with WooCommerce installed and active, apply this PR using the Jetpack Beta tester plugin (or apply locally).

  • Visit WooCommerce > Settings > Accounts + Privacy (/wp-admin/admin.php?page=wc-settings&tab=account), and toggle / change various options
  • View the jetpack-audit* logs for your site and you should see the relevant updated_option actions being logged.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the add/allow-sync-for-woo-accounts-privacy-options branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/allow-sync-for-woo-accounts-privacy-options
bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/allow-sync-for-woo-accounts-privacy-options

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control
Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@coder-karen coder-karen marked this pull request as ready for review April 10, 2026 13:03
@coder-karen coder-karen requested a review from a team as a code owner April 10, 2026 13:03
@coder-karen coder-karen added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Apr 10, 2026
Copy link
Copy Markdown
Contributor

@darssen darssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on adding these options @coder-karen!

I feel that there is a missing WPCOM counterpart before these changes might have impact in WPCOM.

See some prior art with the corresponding WPCOM counterpart.

Copy link
Copy Markdown
Contributor

@darssen darssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that there is a missing WPCOM counterpart before these changes might have impact in WPCOM.

This is not totally correct since Activity Log does show the option synced, even though the cache site doesn't get the changes.

We should be consistent, but as discussed internally, we will handle WPCOM counterpart with future diffs. Unblocking this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Sync [Status] Needs Review This PR is ready for review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants