Skip to content

Fix ignoreSelector filter in wrong place#171

Merged
johngodley merged 1 commit intotrunkfrom
fix/ignore-filter
Mar 12, 2025
Merged

Fix ignoreSelector filter in wrong place#171
johngodley merged 1 commit intotrunkfrom
fix/ignore-filter

Conversation

@johngodley
Copy link
Member

In #168 a fix was put in for the detach event listeners, which weren't being cleared. The part that keeps track of the event handlers was added in the wrong place, and needs to come after we filter the list to remove any elements that have been ignored by the ignoreSelector.

Testing Instructions

  • npm run build
  • npm run start
  • Use the playground page and confirm everything works
  • Press the recycle button to change the order of the avatars on the right and re-attach hovercards. Hover over one and confirm it shows the correct hovercard

It needs to happen before we run the map otherwise we have null elements
@github-actions
Copy link

Size Change: -13 B (-0.02%)

Total Size: 61.7 kB

Filename Size Change
dist/index.esm.js 9.01 kB -2 B (-0.02%)
dist/index.js 9.15 kB -3 B (-0.03%)
dist/index.mjs 9.01 kB -3 B (-0.03%)
dist/index.react.js 11.2 kB -2 B (-0.02%)
dist/index.react.mjs 11.2 kB -3 B (-0.03%)
dist/index.react.umd.js 6.54 kB +1 B (+0.02%)
dist/index.umd.js 5.58 kB -1 B (-0.02%)

compressed-size-action

@johngodley johngodley merged commit 783d884 into trunk Mar 12, 2025
2 checks passed
@johngodley johngodley deleted the fix/ignore-filter branch March 12, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants