Fix ignoreSelector filter in wrong place#171
Merged
johngodley merged 1 commit intotrunkfrom Mar 12, 2025
Merged
Conversation
It needs to happen before we run the map otherwise we have null elements
|
Size Change: -13 B (-0.02%) Total Size: 61.7 kB
|
wellyshen
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #168 a fix was put in for the detach event listeners, which weren't being cleared. The part that keeps track of the event handlers was added in the wrong place, and needs to come after we
filterthe list to remove any elements that have been ignored by theignoreSelector.Testing Instructions
npm run buildnpm run start