Add functions to determine open/close status#170
Merged
johngodley merged 3 commits intotrunkfrom Mar 12, 2025
Merged
Conversation
Add `onClosed` to match `onOpened`, and `close` to match `open`
|
Size Change: +647 B (+9.28%) 🔍 Total Size: 7.62 kB
|
wellyshen
approved these changes
Mar 11, 2025
Contributor
wellyshen
left a comment
There was a problem hiding this comment.
Tested as described and the code LGTM.
| IsOpen, | ||
| OnProfileUpdated, | ||
| OnOpened, | ||
| OnClosed, |
Contributor
There was a problem hiding this comment.
Not mandatory: Maybe we could use export type * from './quick-editor-core'; to free us from manually adding types in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some functions to determine the open/close status of the quick editor. This allows it to be used in situations where you may want to know the QE status so as to change the UI outside of the quick editor.
It will be used in the Gravatar Enhanced plugin so it can disable hovercard interactions while the QE is open, but enable them when it's closed.
Proposed Changes
opento return a boolean indicating whether the popup was successfulonClosedcallback which is called when the popup is closedisOpenfunction to return the open/close statuscloseto programmatically close the popupTesting Instructions
npm run buildnpm run startto open the playground