Skip to content

Export missed methods and types for the React hook and component#167

Merged
wellyshen merged 2 commits intotrunkfrom
export-missed-methods-and-types-for-react
Feb 27, 2025
Merged

Export missed methods and types for the React hook and component#167
wellyshen merged 2 commits intotrunkfrom
export-missed-methods-and-types-for-react

Conversation

@wellyshen
Copy link
Contributor

@wellyshen wellyshen commented Feb 26, 2025

To export more methods and types for the React hook and component

Proposed Changes

  • Export missed methods for the React hook
  • Export missed types for the React hook and component (by using export type * from 'somewhere)
  • (Extra) Format code

Testing Instructions

  • For the types:
    • cd web/packages/hovercards && npm run build
    • In this file, the types should still work
  • For the methods: Code review should be fine

@wellyshen wellyshen self-assigned this Feb 26, 2025
@wellyshen wellyshen requested a review from a team February 26, 2025 18:23
@github-actions
Copy link

Size Change: +23 B (+0.04%)

Total Size: 61.1 kB

Filename Size Change
dist/index.esm.js 8.93 kB -4 B (-0.04%)
dist/index.js 9.07 kB -4 B (-0.04%)
dist/index.mjs 8.92 kB -4 B (-0.04%)
dist/index.react.js 11.1 kB +15 B (+0.14%)
dist/index.react.mjs 11 kB +15 B (+0.14%)
dist/index.react.umd.js 6.48 kB +10 B (+0.15%)
dist/index.umd.js 5.54 kB -5 B (-0.09%)

compressed-size-action

@wellyshen wellyshen merged commit d5944cb into trunk Feb 27, 2025
2 checks passed
@wellyshen wellyshen deleted the export-missed-methods-and-types-for-react branch February 27, 2025 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants