fix(core-webhooks): enable listener when webhooks are enabled#4712
Merged
sebastijankuzner merged 2 commits intodevelopfrom Sep 21, 2022
Merged
fix(core-webhooks): enable listener when webhooks are enabled#4712sebastijankuzner merged 2 commits intodevelopfrom
sebastijankuzner merged 2 commits intodevelopfrom
Conversation
ItsANameToo
approved these changes
Sep 21, 2022
sebastijankuzner
added a commit
that referenced
this pull request
Oct 7, 2022
* Start listeners only when webhooks are enabled * Test service provider
1 task
sebastijankuzner
added a commit
that referenced
this pull request
Oct 13, 2022
* Start listeners only when webhooks are enabled * Test service provider
sebastijankuzner
added a commit
that referenced
this pull request
Nov 23, 2022
* chore(deps): Bump semver-regex from 3.1.3 to 3.1.4 (#4669) Bumps [semver-regex](https://github.com/sindresorhus/semver-regex) from 3.1.3 to 3.1.4. - [Release notes](https://github.com/sindresorhus/semver-regex/releases) - [Commits](https://github.com/sindresorhus/semver-regex/commits/v3.1.4) --- updated-dependencies: - dependency-name: semver-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(crypto): walletVote schema is public key (#4663) * fix(core): remove unused bip38 flag (#4666) * chore: update codeowners (#4673) * Disable fast update (#4671) * fix(crypto): Reduce allocated buffer size for transaction serialization (#4670) * Dynamic buffer size calculation * Fix tests * Lint * fix(core-database): convert vendorField query parameter to buffer (#4672) * Convert vendor field to bufffer * Fix test * deps: update packages with vulnerabilities (#4676) * Yarn.lock * Upgrade @pm2/io * Upgrade protobuff * Update typedoc * Remove cpy-cli * Remove moment * deps: update `lerna` to 5.1.4 (#4677) * Update lerna * Hide execa errors * Remove moment * refactor(core-p2p): get min peer version from `default.ts` instead of milestones (#4680) * Add v4 next into minVersions * Remove version check from milestones * Remove 3.0.0-alpha.0 * fix(core-p2p): skip highest common block search on fast validation (#4681) * Fast verification * Fix tests * Fix mock * Return forked if higgestCommonBlock is not calculated * Add tests * Extract fast verify logic * Fix peer verifier test * Refactor tests * Fix network state * Fix * Peer communicator test * release: 3.4.0 (#4685) * chore(deps): Bump terser from 5.14.1 to 5.14.2 (#4687) Bumps [terser](https://github.com/terser/terser) from 5.14.1 to 5.14.2. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/commits) --- updated-dependencies: - dependency-name: terser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * deps: update packages (#4693) * update yarn.lock * update unused depcheck * Remove unused packages * Add missing packages * update lerna * update got * update npm-check-updates * fix(core-api): use `ITransactionData` in argument with `BlockWithTransactionsResource` (#4688) * fix: prevent new wallet creation in API requests (#4689) * fix(core-kernel): fix item ordering for `undefined` and `null` values in pagination service (#4691) * Fix ordering * Tests * Fix index comparison * refactor(core-api): order resigned delegates by publicKey (#4692) Add order by public key * fix(core-state): create new wallet instance in `WalletRepositoryCopyOnWrite` (#4694) * create new wallet if cannot clone * fix tests * fix(core-p2p): node version should pass min version defined in configuration and milestones (#4695) * Update @arkecosystem/crypto-networks to 1.2.2 * release: 3.5.0 (#4702) * fix(core-api): use block query criteria on delegates route (#4703) * fix(core-api): use block query criteria * lint * fix(core): remove all sqlite files with `pool:clear` command (#4704) * chore: add Boldninja as codeowner (#4708) * release: 3.5.2 (#4707) * chore: update install.sh (#4716) * fix(core-webhooks): use timeout form defaults.ts for broadcast (#4710) * Add timeout from configuration * Fix tests * fix(core-webhooks): enable listener when webhooks are enabled (#4712) * Start listeners only when webhooks are enabled * Test service provider * chore: enable `declarationMap` typescript option (#4717) * feat(core-transactions): implements second and multi signature memoizers (#4714) * Add second signature verification cache * Use LRU-cache * Test SecondSignatureVerificationCache * Rename Cache to Memoizer * Add defaults * Fix * Test defaults * Dependency joi * Cache size from defaults * Identifiers & Contracts * Register memoizer * Fix return type * Replace secondSignatureVefication calls with memoizer * Fix tests * Dependencies lodash * Add MultiSignatureVerificationMemoizer * Test MultiSignatureVerificationMemoizer * Contracts & Identifiers * Bind MultiSignatureVerificationMemoizer * Use multiSignatureVerificationMemoizer * Fix tests * Lint * Fix core-api test * Fix core-magistrate-transactions tests * Replace clonedeep & isequal with methods from @arkecosystem/utils * Move lru-cache under dependencies * Move joi under dependencies * Remove clear method * Fix tests * feat: implements mempool indexes (#4718) * Add mempool index * MempoolIndexRegistry * Support optional index names * Add types * Register registry * Add onPoolEnter & onPoolLeave methods * Register triggers * Use onPoolEnter & onPoolLeave triggers * Fix tests * Use index in DelegateRegistration * DelegateRegistration test * Use index in HtlcClaim * HTLCClaim test * Use index in HTLCRefund * HTLCRefund test * Use index on IPFS * IPFS Test * Use index on MultiSignatureRegistration * MultiSignatureRegistration test * Fix MagistrateTransaction tests * Use correct types on Entity assertions * Use index on Entity * Entity test * Lint * Clear indexes * Mempool clear * Fix core-api tests * Fix core-state integration tests * feat(core-transaction-pool): apply block (#4719) * ApplyBlock contracts * Remove removeForgedTransaction * Implements SenderMempool removeForgedTransaction * implements getInvalidPoolTransactions * Implements applyBlock on mempool * Implements applyBlock on service * Call applyBlock from accept-block-handler * Implements get on mempool-index * Implements getInvalidPoolTransactions on DelegateRegistartion * Implements getInvalidPoolTransactions on SecondSignatureRegistration * Implements getInvalidPoolTransactions on Vote * Implements getInvalidPoolTransactions on DelegateResignation * Implements getInvalidPoolTransactions on HtlcClaim * Implements getInvalidPoolTransactions on HtlcRefund * Implements getInvalidPoolTransactions on Ipfs * Implements getInvalidPoolTransactions on MultiSignatureRegistration * Don't return invalid transactions by same sender * Implements getInvalidPoolTransactions on Entity * Inline * Improve applyBlock * use removeDisposableMempool * Check invalid transactions after forged is removed * refactor(core-transactions): use custom clear on memoized verifiers instead LUR cache (#4720) * Rename folder to verification * Rename interface * Rename class * Rename file * Fix tests * Rename identifiers * Add clear on verifiers * Reorder tests * Change MultiSignatureVerificationMemoized * Chenge SecondSignatureVerificationMemoized * Extract super Cache class * Implements verification proxy classes * Register verifiers * Clear accepts transactionId * Clear cache * Test service * Remove lru-cache dependency * fix(core-blockchain): apply block on transaction-pool after block broadcast (#4721) * apply block is called after broadcast * Remove addTransactions on revert * Don't listen to BuilderFinished * Don't listen to blockApplied * Run apply block exclusive * CleanUp after applyBlock * release: 3.6.0 (#4725) * deps: update lerna to 6.0.3 (#4728) * merge: cherry-pick query optimizer workaround (#4726) (#4730) fix(core-database): query optimizer workaround (#4726) * fix(core-database): query optimizer workaround * Fix only for timestamp in transaction * release: 3.6.1 (#4732) * chore: add install-rc.sh script (#4733) * feat: add support for `rc` channel (#4734) * chore: update github CI for `develop` branch (#4737) chore: update publish-develop.yml gitlab CI * refactor(core-p2p): remove 3.0.0 prereleases (#4739) * release: 3.6.2-rc.0 (#4741) * chore: remove setup python actions from Gitlab workflows (#4742) * Empty commit * remove python for benchmark workflow * Remove setup python action * Remove setup python workflow actions * Fix * Add lodash.clonedepp * chore: update `install-rc.sh` and remove `install-next.sh` (#4744) * chore: update install-rc.sh * remove: install-next.sh * remove install-rc.sh Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: ItsANameToo <35610748+ItsANameToo@users.noreply.github.com> Co-authored-by: boldninja <rok@ark.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable listener only when core-webhooks are enabled. This prevents starting listener and sending webhook POST messages out to previously added webhooks. Webhooks can be enabled with
CORE_WEBHOOKS_ENABLEDflag.Checklist