Fix Compression of DjangoConnector Backups#667
Merged
Archmonger merged 7 commits intoArchmonger:masterfrom Apr 8, 2026
Merged
Conversation
… other connectors.
…koswarf/django-dbbackup into fix/djangoconnector-compress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The DjangoConnector returned a text-mode file, which made the compression code which expected binary as is returned from other connectors to crash with:
Tests don't seem to cover this combination, maybe I will have time to write tests for this, but for now I just needed this fixed for myself.
This also accidentally seems to fix an issue paramiko (SFTP Storage) was having where the os.stat(). Sizes were always larger on the target host vs the source, though the file seemed correct. Did not investigate much, but I suspect it also could be related to utf8 vs on-disk size.
Checklist
Please update this checklist as you complete each item:
By submitting this pull request I agree that all contributions comply with this project's open source license(s).