Conversation
apriltag.c
Outdated
Collaborator
There was a problem hiding this comment.
Isn't this threshold (6) tag family specific? I.e. larger tag families also require larger images.
Contributor
Author
There was a problem hiding this comment.
True, we could make this stricter. For tag16h5, which is the smallest family, we need a minimum size of 8. I've updated the check to this value.
In order to fix #422 we only need to check that the image height is at least 2, so this check is stricter than we need.
Collaborator
There was a problem hiding this comment.
Did you push these changes already? I still see the old threshold of 6 in this PR.
Contributor
Author
There was a problem hiding this comment.
Oops. I've pushed it now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.