Added lerp() function to the point class#16
Open
kadambaridane wants to merge 1 commit intoAppledoreLabs:mainfrom
Open
Added lerp() function to the point class#16kadambaridane wants to merge 1 commit intoAppledoreLabs:mainfrom
kadambaridane wants to merge 1 commit intoAppledoreLabs:mainfrom
Conversation
| } | ||
|
|
||
| // Static function to interpolate between two points | ||
| static Point<T, Dim> lerp(const Point<T, Dim>& p1, const Point<T, Dim>& p2, T t) { |
Collaborator
There was a problem hiding this comment.
You were supposed to add this method in the existing Point class defined in https://github.com/Artifact-Works/GeomCpp/blob/main/Core/Point.hpp
Collaborator
There was a problem hiding this comment.
@SharonIV0x86 Then what should i do now ?
You need to add the lerp method in the Point class. You dont have to create a new Point class from scratch. Additionally kindly delete the test.cpp file its not needed as of now.
SharonIV0x86
added
Hard
Collaborator
|
@kadambaridane Status of your PR? |
2 tasks
Collaborator
|
@kadambaridane This PR is marked as stale, ping maintainer if you'd like to work on it, otherwise this PR will be closed in 12 hours. |
SharonIV0x86
added
the
Stale
Author
|
I apologise for this
…On Sat, 15 Feb 2025, 8:31 pm Anirudh Lakhanpal, ***@***.***> wrote:
@kadambaridane <https://github.com/kadambaridane> This PR is marked as
stale, ping maintainer if you'd like to work on it, otherwise this PR will
be closed in 12 hours.
—
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIUG7GZYKFQYRT2RLEQID3L2P5JFNAVCNFSM6AAAAABW4GT5UGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRQHE3DCNJUHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: SharonIV0x86]*SharonIV0x86* left a comment
(AppledoreLabs/GeomCpp#16)
<#16 (comment)>
@kadambaridane <https://github.com/kadambaridane> This PR is marked as
stale, ping maintainer if you'd like to work on it, otherwise this PR will
be closed in 12 hours.
—
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIUG7GZYKFQYRT2RLEQID3L2P5JFNAVCNFSM6AAAAABW4GT5UGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRQHE3DCNJUHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Author
|
It is not working properly from my side, You can assign to any other 🙏
On Sat, 15 Feb 2025, 8:56 pm Kadambari Dane, ***@***.***>
wrote:
… I apologise for this
On Sat, 15 Feb 2025, 8:31 pm Anirudh Lakhanpal, ***@***.***>
wrote:
> @kadambaridane <https://github.com/kadambaridane> This PR is marked as
> stale, ping maintainer if you'd like to work on it, otherwise this PR will
> be closed in 12 hours.
>
> —
> Reply to this email directly, view it on GitHub
> <#16 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BIUG7GZYKFQYRT2RLEQID3L2P5JFNAVCNFSM6AAAAABW4GT5UGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRQHE3DCNJUHE>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
> [image: SharonIV0x86]*SharonIV0x86* left a comment
> (AppledoreLabs/GeomCpp#16)
> <#16 (comment)>
>
> @kadambaridane <https://github.com/kadambaridane> This PR is marked as
> stale, ping maintainer if you'd like to work on it, otherwise this PR will
> be closed in 12 hours.
>
> —
> Reply to this email directly, view it on GitHub
> <#16 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BIUG7GZYKFQYRT2RLEQID3L2P5JFNAVCNFSM6AAAAABW4GT5UGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRQHE3DCNJUHE>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Collaborator
I can assign this to someone else, but if you need any help just let me know. |
Author
|
Sorry sir but in my server it's not running properly
…On Sat, 15 Feb 2025, 8:59 pm Anirudh Lakhanpal, ***@***.***> wrote:
It is not working properly from my side, You can assign to any other 🙏 On
Sat, 15 Feb 2025, 8:56 pm Kadambari Dane,
I can assign this to someone else, but if you need any help just let me
know.
—
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIUG7G3TPGGZFXXANBEZROL2P5MNJAVCNFSM6AAAAABW4GT5UGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRQHE3TCNZZGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: SharonIV0x86]*SharonIV0x86* left a comment
(AppledoreLabs/GeomCpp#16)
<#16 (comment)>
It is not working properly from my side, You can assign to any other 🙏 On
Sat, 15 Feb 2025, 8:56 pm Kadambari Dane,
I can assign this to someone else, but if you need any help just let me
know.
—
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIUG7G3TPGGZFXXANBEZROL2P5MNJAVCNFSM6AAAAABW4GT5UGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRQHE3TCNZZGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Collaborator
|
I will close this PR, if you'd like to work on any other issue let me know, i'll guide you from there. |
Author
|
Sure
Thanks 😊
…On Sat, 15 Feb 2025, 9:08 pm Anirudh Lakhanpal, ***@***.***> wrote:
I will close this PR, if you'd like to work on any other issue let me
know, i'll guide you from there.
You can take a look at existing issues:
https://github.com/Artifact-Works/GeomCpp/issues
—
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIUG7G3QAGWHHTYU26NKKKT2P5NN3AVCNFSM6AAAAABW4GT5UGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRQHE3TINZVGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: SharonIV0x86]*SharonIV0x86* left a comment
(AppledoreLabs/GeomCpp#16)
<#16 (comment)>
I will close this PR, if you'd like to work on any other issue let me
know, i'll guide you from there.
You can take a look at existing issues:
https://github.com/Artifact-Works/GeomCpp/issues
—
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIUG7G3QAGWHHTYU26NKKKT2P5NN3AVCNFSM6AAAAABW4GT5UGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRQHE3TINZVGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.