fixes #1 and makes the lib build and test on new Node + Windows platforms #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on any machine/platform.
…sso (which requires special C compiler build action on Windows platforms and is outmoded anyway)
…agraph wrapping is buggy. :-(((((((((((
…nes, not vice versa! - added sanity checking to the most important input parameters: must be sane numbers.
…lowing arbitrary line breaks in the input, but outputting the requested type (Windows, Unix, Mac). Garbage in, Sanity out.
…ed. WARNING: `multiLineBreak` regex is *NOT* a multi-linebreak regex but something else instead: it gobbles all whitespace around a single lineBreak, including other lineBreaks!
// any 'multiple linebreak' regex should have the pattern: \s*\n(\s*\n)+
// where \n represents the lineBreak of choice.
//
…our patch ASAP and use it anywhere (e.g. nomnom -> jison).
… be crlf/lf/cr converted by GIT but should instead be treated as 'raw' input for the tests!
…nt reports. Used extra eslint config files for the example and test directories to quickly shut the linter up for those codebases, which (IMO) don't need to be treated as strict as the library itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commits; the patch for #1 can be easily separated out.
The other useful stuff in here: