[codex] Add Groovy formula DSL docs and verification close-out#291
Merged
[codex] Add Groovy formula DSL docs and verification close-out#291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finish the Groovy formula DSL work for
matrix-statsby landing the section 4 fit helpers, the DSL follow-up fixes, the section 5 documentation updates, and the final section 6 verification record.What Changed
FitDslconvenience entry points forlm,loess, andgamFitDslparity againstFitRegistry.instance().get(...).fit(ModelFrame.of(...).evaluate())|handling inTermExprso non-variable response shapes report the formula-specific error instead of Groovy's generic missing-method erroror(...)overrides from formula DSL subclasses once the base implementation was in placematrix-stats/README.md,docs/tutorial/3-matrix-stats.md, anddocs/cookbook/matrix-stats.mdmatrix-stats/release.mdmatrix-stats/req/v2.4.0-groovyFormulas.mdthrough section 6 with the recorded validation commandsWhy
The Groovy formula work needed three things to be complete:
lm(data) { ... }without manually building aModelFrameUser Impact
Callers can now write:
lm(data) { y | x + group } loess(data) { y | x } gam(data) { y | smooth(time, 6) + group }The docs now also describe:
|andnoIntercept)propertyMissing/ operator-dispatch behaviorI { ... }interaction(x, group, z)for three-way interactionsValidation
GRADLE_USER_HOME=$PWD/.gradle-user ./gradlew :matrix-stats:test --tests 'formula.GroovyFormulaDslTest'GRADLE_USER_HOME=$PWD/.gradle-user ./gradlew :matrix-stats:test --tests 'formula.*' --tests 'regression.*'GRADLE_USER_HOME=$PWD/.gradle-user ./gradlew :matrix-stats:spotlessApply :matrix-stats:test :matrix-stats:codenarcMain :matrix-stats:codenarcTestgit diff --check -- matrix-stats/README.md docs/tutorial/3-matrix-stats.md docs/cookbook/matrix-stats.md matrix-stats/release.mdGRADLE_USER_HOME=$PWD/.gradle-user ./gradlew testAll of the above passed. The final full-repo run completed with: