[Common,PWGHF] Add reduced q vectors for Event-shape Engineering#15636
Open
Marcellocosti wants to merge 5 commits intoAliceO2Group:masterfrom
Open
[Common,PWGHF] Add reduced q vectors for Event-shape Engineering#15636Marcellocosti wants to merge 5 commits intoAliceO2Group:masterfrom
Marcellocosti wants to merge 5 commits intoAliceO2Group:masterfrom
Conversation
|
O2 linter results: ❌ 17 errors, |
github-actions
bot
changed the title
Marcellocosti
force-pushed
the
red_q_vecs
branch
from
19fa6cb to
daf7eb2
Compare
Please consider the following formatting changes to AliceO2Group#15636
Marcellocosti
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jgrosseo,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
Marcellocosti
requested review from
a team,
ddobrigk,
dsekihat,
iarsene and
ktf
as code owners
stefanopolitano
approved these changes
Apr 2, 2026
vkucera
reviewed
Apr 3, 2026
Comment on lines
+774
to
+777
| for (std::size_t iTrack = 0; iTrack < tracksRedQx.size(); ++iTrack) { | ||
| xRedQVec -= tracksRedQx[iTrack]; | ||
| yRedQVec -= tracksRedQy[iTrack]; | ||
| } |
Collaborator
There was a problem hiding this comment.
How about using std::accumulate?
Comment on lines
+781
to
+784
| redQVec = std::sqrt(xRedQVec * xRedQVec + yRedQVec * yRedQVec) * amplRedQVec / std::sqrt(amplRedQVec - tracksRedQx.size()); | ||
| } else { | ||
| redQVec = std::sqrt(xRedQVec * xRedQVec + yRedQVec * yRedQVec) * std::sqrt(amplRedQVec); | ||
| } |
Collaborator
There was a problem hiding this comment.
How about using std::hypot?
| // taking into account that the Q-vector is normalized by 1/M | ||
| // and the EsE reduced Q-vector must be normalized to 1/sqrt(M) | ||
| if (useDetector["QvectorFT0Cs"]) { | ||
| qVecRedFT0C = TMath::Sqrt(qvecReFT0C.at(0) * qvecReFT0C.at(0) + qvecImFT0C.at(0) * qvecImFT0C.at(0)) * TMath::Sqrt(qvecAmp[kFT0C]); |
Collaborator
There was a problem hiding this comment.
Why don't you use std::sqrt and std::hypot?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.