Skip to content

[PWGEM] New Dielectron analysis type: Bootstrapping for v2.#15576

Merged
dsekihat merged 11 commits intoAliceO2Group:masterfrom
omassen:EMDevBranch
Apr 2, 2026
Merged

[PWGEM] New Dielectron analysis type: Bootstrapping for v2.#15576
dsekihat merged 11 commits intoAliceO2Group:masterfrom
omassen:EMDevBranch

Conversation

@omassen
Copy link
Copy Markdown
Contributor

@omassen omassen commented Mar 30, 2026

Introducing a new analysis type for performing poisson bootstrapping for the dielectron v2 analysis. This includes:

  • changes to the EventHistorgams.h to introduce new histograms per bootstrapping sample and a method of filling them
  • Small change to PairUtils.h to be able to choose the new analysis type.
  • In Dilepton.h implementing the new analysis. Existing code could for the main part remain untouched. The only change to the existing code is the introduction of a new argument for the FillPairInfo function, needed to parse the bootstrap weights.

@github-actions github-actions bot added the pwgem label Mar 30, 2026
@github-actions github-actions bot changed the title New Dielectron analysis type: Bootstrapping for v2. [PWGEM] New Dielectron analysis type: Bootstrapping for v2. Mar 30, 2026
@omassen omassen marked this pull request as ready for review March 31, 2026 13:23
@omassen omassen marked this pull request as draft April 2, 2026 07:41
@omassen
Copy link
Copy Markdown
Contributor Author

omassen commented Apr 2, 2026

Working on resolving new merge conflicts due to PR #15385

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

O2 linter results: ❌ 136 errors, ⚠️ 250 warnings, 🔕 0 disabled

@dsekihat
Copy link
Copy Markdown
Collaborator

dsekihat commented Apr 2, 2026

Hi Olaf, It looks good from my side.

Please consider the following formatting changes to AliceO2Group#15576
@omassen omassen marked this pull request as ready for review April 2, 2026 11:22
@omassen
Copy link
Copy Markdown
Contributor Author

omassen commented Apr 2, 2026

Merge conflicts have been resolved, should be good to go now.

@dsekihat
Copy link
Copy Markdown
Collaborator

dsekihat commented Apr 2, 2026

It is not required by the system, it would be nicer if you can solve the test build build/O2Physics/o2/macOS.

@omassen
Copy link
Copy Markdown
Contributor Author

omassen commented Apr 2, 2026

I have done some checks but the issues with this test build were already there for the previous PR #15385. I have tried to take a look but to me it is not clear how to solve this. I am also not able to replicate these issues locally, as I have MacOS-arm.

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 2, 2026

I have done some checks but the issues with this test build were already there for the previous PR #15385. I have tried to take a look but to me it is not clear how to solve this. I am also not able to replicate these issues locally, as I have MacOS-arm.

It's reported by O2 linter, Clang-Tidy, and Clangd. It doesn't matter what OS you have.

Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 2, 2026

I have done some checks but the issues with this test build were already there for the previous PR #15385. I have tried to take a look but to me it is not clear how to solve this. I am also not able to replicate these issues locally, as I have MacOS-arm.

It's reported by O2 linter, Clang-Tidy, and Clangd. It doesn't matter what OS you have.

Sorry, I misunderstood what the comment was referring to.

@dsekihat dsekihat merged commit a390108 into AliceO2Group:master Apr 2, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants