Adjustments for PWGHF embedding benchmark#3
Merged
sawenzel merged 1 commit intoAliceO2Group:masterfrom Nov 6, 2020
Merged
Conversation
SHMSIZE adjustment (learning from first GRID exercise)
miranov25
pushed a commit
to miranov25/O2DPG
that referenced
this pull request
Dec 12, 2025
New features: - get_required_branches() public method for branch detection - AST-based selection string parsing (_parse_selection_columns) - Alias chain resolution to base branches (_resolve_to_base_branches) - Regex fallback for unparseable expressions - validate=True filters to existing branches (lazy & eager modes) Design decisions (unanimous reviewer approval): - (a) AST parsing for accuracy with physics expressions - (b) Filter function names from results (np, sqrt, abs, etc.) - (a) Raise error on circular aliases - (a) Public API for user debugging GPT tweaks implemented: - #1: Get ALL columns from expr, not just aliases - AliceO2Group#2: Shared _visited set with add/remove pattern - AliceO2Group#3: validate works in both lazy AND eager modes - AliceO2Group#4: Helper methods kept private Tests: 51 new tests, 1014 total passing
miranov25
pushed a commit
to miranov25/O2DPG
that referenced
this pull request
Apr 2, 2026
- weights='(1+mP4**2)' was silently treated as unweighted - Root cause: 'weights in df.columns' fails for expressions - Fix: _eval_weights() — column name, then df.eval(), then ValueError - Hard Constraint AliceO2Group#3 (Safety) violated: silent wrong results - 5 new tests in TestWeightExpressions, 21/21 passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SHMSIZE adjustment (learning from first GRID exercise)