JSON format stores multi-line string for SSH keys

[newlog]

Hi again,

I saw that when an SSH key is found, when saved in JSON format to a file, the SSH key is written as a multi-line string. JSON format does not support multi-line strings, thus failing when trying to load that data with the Python json module.

More info can be found here:

• https://stackoverflow.com/questions/16690101/can-a-json-value-contain-a-multiline-string

Problematic output example:

"Passwords": [
            [
                {
                    "Category": "Ssh"
                },
                [
                    {
                        "KEY": "-----BEGIN RSA PRIVATE KEY-----
<string>
<string>
<string>

If a json.load() is executed upon that data, it will fail, rendering the feature of storing data as json kind of useless.

[newlog]

Also, there's another problem with the generated json data.

With firefox passwords the following entry is generated:

"Password": "{"version":1,"accountData":{"<data1>":"<data2>","<data3>":"<data4>"}}",

The double quote enclosing the dictionary inside "Password", also makes the Python json.load() fail. If those are removed, the json is properly loaded. Example:

"Password": {"version":1,"accountData":{"<data1>":"<data2>","<data3>":"<data4>"}},

[newlog]

Finally, the format of the generated json is kind of convoluted. If anyone is wondering how to parse it (if those issues get fixed), you can use this:

def _parse_lazagne_json(self, json_data):
    results = {}
    for pwd_items in json_data[0]['Passwords']:
      try:
        source = pwd_items[0]['Category'].lower()
        lazagne_obj = pwd_items[1]
        results[source] = {'lazagne_cred': lazagne_obj, 'count': len(lazagne_obj)}
      except Exception as ex:
        self.log_error('Error parsing LaZagne json entry. Error: {}'.format(ex))
    return results

At the same time, just to contribute a little bit more, if someone wants to parse the stdout, this regular expression (within the method) can be used:

  def _parse_lazagne_stdout(self, output):
    results = {}
    output = self._clean_ansi_escape_sequences(output)
    lazagne_entries = re.findall('-{19} (.*?) -{17}\s+(.*?(?:(?=\n{3}\[.?\])|(?=-{19})))', output, re.S)
    if lazagne_entries:
      results = self._build_results(lazagne_entries)
    return results

Hope this is helpful to anyone.

[AlessandroZ]

I have added a link to this issue on the Readme. Thanks for your help.