Work around usage of CachedJarFileCallback#969
Draft
blackdrag wants to merge 1 commit intoAdoptOpenJDK:masterfrom
Draft
Work around usage of CachedJarFileCallback#969blackdrag wants to merge 1 commit intoAdoptOpenJDK:masterfrom
blackdrag wants to merge 1 commit intoAdoptOpenJDK:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Java24 the interface URLJarFileCallBack is removed as well as the mechanism behind it. This mechanism allows to intercept the download of a JAR in for example a class loader to add custom logic. Because of us setting CachedJarFileCallback actively and that class implementing the now no longer available interface the execution on Java 24 fails with a ClassNotFoundException.
This PR tries to keep the mechanism for the class loader as good as possible by using the tracker logic directly and removes the callbacks.
One disadvantage is that the class loader no longer shows the remote URLs in the classpath.